From: Anjelique Melendez <quic_amelende@quicinc.com>
To: Rob Herring <robh@kernel.org>
Cc: <pavel@ucw.cz>, <lee@kernel.org>, <thierry.reding@gmail.com>,
<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
<agross@kernel.org>, <andersson@kernel.org>,
<luca.weiss@fairphone.com>, <konrad.dybcio@linaro.org>,
<u.kleine-koenig@pengutronix.de>, <quic_subbaram@quicinc.com>,
<linux-leds@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
<linux-pwm@vger.kernel.org>
Subject: Re: [PATCH v2 2/7] dt-bindings: leds: leds-qcom-lpg: Add support for LPG PPG
Date: Mon, 7 Aug 2023 13:03:05 -0700 [thread overview]
Message-ID: <900b3b16-cfad-d043-39b4-8ea6802f87bc@quicinc.com> (raw)
In-Reply-To: <20230803002502.GA1569972-robh@kernel.org>
On 8/2/2023 5:25 PM, Rob Herring wrote:
> On Tue, Jul 25, 2023 at 12:34:18PM -0700, Anjelique Melendez wrote:
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + enum:
>> + - qcom,pm8350c-pw
>> + - qcom,pm8550-pwm
>> + then:
>> + properties:
>> + nvmem:
>> + minItems: 2
>> + nvmem-names:
>> + items:
>> + - const: lpg_chan_sdam
>> + - const: lut_sdam
>
> This can go into the main section and then here you just say
> 'minItems: 2'. And similar for the 1st if/then.
>
ACK
>> + required:
>> + - nvmem
>> + - nvmem-names
>
> Looks like these are always required.
These are only required for the compatibles properties that do not
have lut peripherals. Right now this is is only for qcom,pmi632-lpg,
qcom,pm8350c-pwm and qcom,pm8550-pwm.
next prev parent reply other threads:[~2023-08-07 20:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-25 19:34 [PATCH v2 0/7] Add support for LUT PPG Anjelique Melendez
2023-07-25 19:34 ` [PATCH v2 1/7] dt-bindings: soc: qcom: Add qcom-pbs bindings Anjelique Melendez
2023-07-25 20:49 ` Rob Herring
2023-07-26 7:53 ` Krzysztof Kozlowski
2023-07-31 18:19 ` Anjelique Melendez
2023-07-25 19:34 ` [PATCH v2 2/7] dt-bindings: leds: leds-qcom-lpg: Add support for LPG PPG Anjelique Melendez
2023-08-03 0:25 ` Rob Herring
2023-08-07 20:03 ` Anjelique Melendez [this message]
2023-07-25 19:34 ` [PATCH v2 3/7] soc: qcom: add QCOM PBS driver Anjelique Melendez
2023-07-26 15:36 ` Konrad Dybcio
2023-07-31 19:22 ` Bjorn Andersson
2023-08-01 18:48 ` Anjelique Melendez
2023-07-27 5:06 ` Dan Carpenter
2023-07-31 18:25 ` Trilok Soni
2023-07-25 19:34 ` [PATCH v2 4/7] leds: rgb: leds-qcom-lpg: Add support for PPG through single SDAM Anjelique Melendez
2023-07-25 19:34 ` [PATCH v2 5/7] leds: rgb: leds-qcom-lpg: Update PMI632 lpg_data to support PPG Anjelique Melendez
2023-07-25 19:34 ` [PATCH v2 6/7] leds: rgb: leds-qcom-lpg: Support two-nvmem PPG Scheme Anjelique Melendez
2023-07-25 19:34 ` [PATCH v2 7/7] leds: rgb: Update PM8350C lpg_data to support " Anjelique Melendez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=900b3b16-cfad-d043-39b4-8ea6802f87bc@quicinc.com \
--to=quic_amelende@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=pavel@ucw.cz \
--cc=quic_subbaram@quicinc.com \
--cc=robh@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox