From: Hans de Goede <hdegoede@redhat.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jani Nikula <jani.nikula@linux.intel.com>
Cc: linux-pwm@vger.kernel.org,
intel-gfx <intel-gfx@lists.freedesktop.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: Re: [PATCH v2] pwm: lpss: Make builtin so that i915 can find the pwm_backlight
Date: Fri, 20 Jan 2017 11:18:29 +0100 [thread overview]
Message-ID: <94d3254b-c658-526d-dd5e-173aad9779c6@redhat.com> (raw)
In-Reply-To: <1484906109.2133.262.camel@linux.intel.com>
Hi,
On 20-01-17 10:55, Andy Shevchenko wrote:
> On Fri, 2017-01-20 at 10:48 +0100, Hans de Goede wrote:
>> I'm fine with doing a v3 with a comment, how about putting that
>> comment
>> right at all the module* stuff and explain there that that is to
>> stay as the builtin only status is meant to be temporary ?
>
> Can we do other way around? I mean that either i915 selects PWM_LPSS to
> be built-in, or uses request_module() call?
PWM_LPSS needs to be built-in if enabled, a stripped down kernel
for non cherrytrail hardware does not need it ...
Also (and esp for request_module) this means building knowledge
into the i915 driver about which pwm hardware there is on which
boards which is undesirable.
Thierry, this does give me an idea though, what if we extend
the info passed to pwm_add_table with a module-name and
make pwm_get call request_module() ?
That seems like a good solution and we could then also make
PWM_CRC a tristate again (after someone with hw access has tested
this).
Regards,
Hans
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-01-20 10:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 17:58 [PATCH v2] pwm: lpss: Make builtin so that i915 can find the pwm_backlight Hans de Goede
2017-01-20 7:03 ` Thierry Reding
2017-01-20 7:18 ` Thierry Reding
2017-01-20 7:50 ` Hans de Goede
2017-01-20 8:02 ` Jani Nikula
2017-01-20 8:56 ` Thierry Reding
2017-01-20 9:48 ` Hans de Goede
2017-01-20 9:55 ` Andy Shevchenko
2017-01-20 10:18 ` Hans de Goede [this message]
2017-01-20 10:42 ` Thierry Reding
2017-01-22 16:21 ` Hans de Goede
2017-01-20 9:58 ` Thierry Reding
2017-01-20 9:55 ` Mika Westerberg
2017-03-08 9:40 ` Jani Nikula
2017-03-08 9:48 ` Hans de Goede
2017-03-08 10:15 ` Jani Nikula
2017-03-08 13:41 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94d3254b-c658-526d-dd5e-173aad9779c6@redhat.com \
--to=hdegoede@redhat.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=linux-pwm@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox