From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Angelo Compagnucci <angelo.compagnucci@gmail.com>,
linux-pwm@vger.kernel.org
Subject: Re: [PATCH] misc: servo-pwm: driver for controlling servo motors via PWM
Date: Wed, 13 Jan 2021 10:47:55 +0100 [thread overview]
Message-ID: <X/7By1uFKhucSxuB@kroah.com> (raw)
In-Reply-To: <20210113093546.5v7kbjoog64dfpij@pengutronix.de>
On Wed, Jan 13, 2021 at 10:35:46AM +0100, Uwe Kleine-König wrote:
> [Cc += gregkh]
>
> On Tue, Dec 22, 2020 at 10:33:42PM +0100, Angelo Compagnucci wrote:
> > +static int servo_pwm_probe(struct platform_device *pdev)
> > +{
> > [...]
> > + ret = devm_device_add_groups(&pdev->dev, servo_pwm_groups);
>
> There are very little cases where calling this function is correct and
> I think in the probe function of a platform driver it's always wrong.
That is correct, just set the platform driver's default groups pointer
and all will be handled properly and automatically.
As mentioned on IRC, this patch isn't describing these new sysfs files
in Documentation/ABI/ which is required for new files. Angelo, for the
next version, please do that, thanks!
greg k-h
prev parent reply other threads:[~2021-01-13 9:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-22 21:33 [PATCH] misc: servo-pwm: driver for controlling servo motors via PWM Angelo Compagnucci
2021-01-12 20:45 ` Uwe Kleine-König
2021-01-13 9:35 ` Uwe Kleine-König
2021-01-13 9:47 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X/7By1uFKhucSxuB@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=angelo.compagnucci@gmail.com \
--cc=linux-pwm@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox