Re: [thierry-reding-pwm:for-next 10/13] drivers/pwm/pwm-dwc.c:314:1: warning: data definition has no type or storage class

[Thierry Reding <thierry.reding@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 3593 bytes --]

On Mon, Feb 20, 2023 at 08:39:43AM +0000, Ben Dooks wrote:
> On 17/02/2023 21:53, kernel test robot wrote:
> > Hi Ben,
> > 
> > FYI, the error/warning was bisected to this commit, please ignore it if it's irrelevant.
> > 
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/thierry.reding/linux-pwm.git for-next
> > head:   7a77daf8223e772a225d6aa6202a5b1ae2392caf
> > commit: c901a57e39db555ad7950fd61e1470cdecc8e654 [10/13] pwm: dwc: allow driver to be built with COMPILE_TEST
> > config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230218/202302180504.FZilVS8T-lkp@intel.com/config)
> > compiler: m68k-linux-gcc (GCC) 12.1.0
> > reproduce (this is a W=1 build):
> >          wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >          chmod +x ~/bin/make.cross
> >          # https://git.kernel.org/pub/scm/linux/kernel/git/thierry.reding/linux-pwm.git/commit/?id=c901a57e39db555ad7950fd61e1470cdecc8e654
> >          git remote add thierry-reding-pwm https://git.kernel.org/pub/scm/linux/kernel/git/thierry.reding/linux-pwm.git
> >          git fetch --no-tags thierry-reding-pwm for-next
> >          git checkout c901a57e39db555ad7950fd61e1470cdecc8e654
> >          # save the config file
> >          mkdir build_dir && cp config build_dir/.config
> >          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k olddefconfig
> >          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/pwm/
> > 
> > If you fix the issue, kindly add following tag where applicable
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Link: https://lore.kernel.org/oe-kbuild-all/202302180504.FZilVS8T-lkp@intel.com/
> > 
> > All warnings (new ones prefixed by >>):
> > 
> > > > drivers/pwm/pwm-dwc.c:314:1: warning: data definition has no type or storage class
> >       314 | module_pci_driver(dwc_pwm_driver);
> >           | ^~~~~~~~~~~~~~~~~
> >     drivers/pwm/pwm-dwc.c:314:1: error: type defaults to 'int' in declaration of 'module_pci_driver' [-Werror=implicit-int]
> > > > drivers/pwm/pwm-dwc.c:314:1: warning: parameter names (without types) in function declaration
> >     drivers/pwm/pwm-dwc.c:304:26: warning: 'dwc_pwm_driver' defined but not used [-Wunused-variable]
> >       304 | static struct pci_driver dwc_pwm_driver = {
> >           |                          ^~~~~~~~~~~~~~
> >     cc1: some warnings being treated as errors
> > 
> > 
> > vim +314 drivers/pwm/pwm-dwc.c
> > 
> > 1ed2b3fca64516 Jarkko Nikula 2020-10-02  313
> > 1ed2b3fca64516 Jarkko Nikula 2020-10-02 @314  module_pci_driver(dwc_pwm_driver);
> > 1ed2b3fca64516 Jarkko Nikula 2020-10-02  315
> > 
> > :::::: The code at line 314 was first introduced by commit
> > :::::: 1ed2b3fca64516d1b3503ef21929f3b5f4f41cc6 pwm: Add DesignWare PWM Controller Driver
> > 
> > :::::: TO: Jarkko Nikula <jarkko.nikula@linux.intel.com>
> > :::::: CC: Thierry Reding <thierry.reding@gmail.com>
> > 
> 
> I'm guessing that there's no PCI support on mk86 and therefore having
> compile test set with no PCI before we split the PCI and OF bits may
> have been a mistake.
> 
> Should we fix this by adding a test for PCI here, or move it to be
> after the driver split so the PCI driver will only get built if the
> architecture has PCI?

I've dropped this patch now since it's obviously wrong (at the moment).
If this can be made to work after the split, let's do it then.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]