From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AF0AC4332F for ; Sun, 4 Dec 2022 21:31:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229954AbiLDVbs (ORCPT ); Sun, 4 Dec 2022 16:31:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229949AbiLDVbr (ORCPT ); Sun, 4 Dec 2022 16:31:47 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89F8613E05 for ; Sun, 4 Dec 2022 13:31:46 -0800 (PST) Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 0BFC92D8; Sun, 4 Dec 2022 22:31:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1670189504; bh=ZiU22BSfaBf2V1IOu/eKj4zw3NqHJMR9VyBBSYl+1Ic=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ldTI9peQD33DfV0DUvPhXdJ5gTCbmm5NGmDoSA082azM8dhTFFtbjHWz9P80J8duS IzUs9ruF05OCEwTVeqHu+UbSpAgcMEwT/R3OqVoOU3QgTqEAEdgBrdORRd/8NPksme bTMyPSI3RTylqWUFz9oBmBWE1G8O1chH2T4HOQlo= Date: Sun, 4 Dec 2022 23:31:42 +0200 From: Laurent Pinchart To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Thierry Reding , Andrzej Hajda , Neil Armstrong , Robert Foss , Conor Dooley , Douglas Anderson , dri-devel@lists.freedesktop.org, linux-pwm@vger.kernel.org, Jonas Karlman , Jernej Skrabec , Daniel Vetter Subject: Re: [PATCH v2 03/11] drm/bridge: ti-sn65dsi86: Propagate errors in .get_state() to the caller Message-ID: References: <20221130152148.2769768-1-u.kleine-koenig@pengutronix.de> <20221130152148.2769768-4-u.kleine-koenig@pengutronix.de> <20221204210940.qygblu244zvlenxz@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221204210940.qygblu244zvlenxz@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org On Sun, Dec 04, 2022 at 10:09:40PM +0100, Uwe Kleine-König wrote: > Hello, > > my initial Cc-list wasn't optimal. So I added a few people here. > > On Wed, Nov 30, 2022 at 04:21:40PM +0100, Uwe Kleine-König wrote: > > .get_state() can return an error indication. Make use of it to propagate > > failing hardware accesses. > > > > Signed-off-by: Uwe Kleine-König Reviewed-by: Laurent Pinchart > > --- > > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > > index 6826d2423ae9..9671071490d8 100644 > > --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c > > +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > > @@ -1512,19 +1512,19 @@ static int ti_sn_pwm_get_state(struct pwm_chip *chip, struct pwm_device *pwm, > > > > ret = regmap_read(pdata->regmap, SN_PWM_EN_INV_REG, &pwm_en_inv); > > if (ret) > > - return 0; > > + return ret; > > > > ret = ti_sn65dsi86_read_u16(pdata, SN_BACKLIGHT_SCALE_REG, &scale); > > if (ret) > > - return 0; > > + return ret; > > > > ret = ti_sn65dsi86_read_u16(pdata, SN_BACKLIGHT_REG, &backlight); > > if (ret) > > - return 0; > > + return ret; > > > > ret = regmap_read(pdata->regmap, SN_PWM_PRE_DIV_REG, &pre_div); > > if (ret) > > - return 0; > > + return ret; > > > > state->enabled = FIELD_GET(SN_PWM_EN_MASK, pwm_en_inv); > > if (FIELD_GET(SN_PWM_INV_MASK, pwm_en_inv)) > > It would be great to get an Ack to take this patch and patch #1 via the > PWM tree. (Both got an Ack by Douglas Anderson, I'm unsure if that is > already enough.) -- Regards, Laurent Pinchart