From: Clemens Gruber <clemens.gruber@pqgruber.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-pwm@vger.kernel.org,
Thierry Reding <thierry.reding@gmail.com>,
Sven Van Asbroeck <TheSven73@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
linux-kernel@vger.kernel.org,
Mika Westerberg <mika.westerberg@linux.intel.com>,
David Jander <david@protonic.nl>
Subject: Re: [PATCH v5 1/7] pwm: pca9685: Switch to atomic API
Date: Thu, 4 Mar 2021 14:12:04 +0100 [thread overview]
Message-ID: <YEDcpAtQAc2Mu6Wz@workstation.tuxnet> (raw)
In-Reply-To: <20210301214407.4xitetvqbsdoer6w@pengutronix.de>
Hi Uwe,
On Mon, Mar 01, 2021 at 10:44:07PM +0100, Uwe Kleine-König wrote:
> Hello Clemens,
>
> On Tue, Dec 15, 2020 at 10:22:22PM +0100, Clemens Gruber wrote:
> > + if (state->polarity != PWM_POLARITY_NORMAL)
> > + return -EOPNOTSUPP;
>
> We agreed on -EINVAL for that one since 2b1c1a5d5148.
>
> Other than that the patch looks ok (but note I only looked quickly).
Thanks for looking over it. This will be -EINVAL in the next revision.
Best regards,
Clemens
prev parent reply other threads:[~2021-03-04 13:13 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 21:22 [PATCH v5 1/7] pwm: pca9685: Switch to atomic API Clemens Gruber
2020-12-15 21:22 ` [PATCH v5 2/7] pwm: pca9685: Support hardware readout Clemens Gruber
2020-12-15 21:22 ` [PATCH v5 3/7] pwm: pca9685: Improve runtime PM behavior Clemens Gruber
2020-12-15 21:22 ` [PATCH v5 4/7] pwm: pca9685: Reset registers to POR state in probe Clemens Gruber
2020-12-17 4:02 ` Sven Van Asbroeck
2020-12-17 17:45 ` Clemens Gruber
2021-03-01 21:46 ` Uwe Kleine-König
2021-03-04 13:16 ` Clemens Gruber
2020-12-15 21:22 ` [PATCH v5 5/7] pwm: pca9685: Support staggered output ON times Clemens Gruber
2020-12-17 4:02 ` Sven Van Asbroeck
2020-12-17 17:50 ` Clemens Gruber
2020-12-15 21:22 ` [PATCH v5 6/7] dt-bindings: pwm: pca9685: Add nxp,staggered-outputs property Clemens Gruber
2020-12-15 21:22 ` [PATCH v5 7/7] pwm: pca9685: Restrict period change for prescaler users Clemens Gruber
2020-12-17 4:03 ` Sven Van Asbroeck
2020-12-17 18:07 ` Clemens Gruber
2020-12-17 18:17 ` Sven Van Asbroeck
2020-12-17 3:58 ` [PATCH v5 1/7] pwm: pca9685: Switch to atomic API Sven Van Asbroeck
2020-12-17 16:48 ` Clemens Gruber
2020-12-17 17:10 ` Sven Van Asbroeck
2021-03-01 21:41 ` Uwe Kleine-König
2021-03-04 13:10 ` Clemens Gruber
2021-03-22 7:58 ` Thierry Reding
2021-03-27 15:54 ` Clemens Gruber
2021-03-01 21:44 ` Uwe Kleine-König
2021-03-04 13:12 ` Clemens Gruber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEDcpAtQAc2Mu6Wz@workstation.tuxnet \
--to=clemens.gruber@pqgruber.com \
--cc=TheSven73@gmail.com \
--cc=david@protonic.nl \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).