From: Greg KH <gregkh@linuxfoundation.org>
To: Guru Das Srinagesh <gurus@codeaurora.org>
Cc: linux-pwm@vger.kernel.org,
Thierry Reding <thierry.reding@gmail.com>,
kernel-team@android.com, Mark Salyzyn <salyzyn@google.com>,
Sandeep Patil <sspatil@google.com>,
Subbaraman Narayanamurthy <subbaram@codeaurora.org>,
linux-kernel@vger.kernel.org,
Fenglin Wu <fenglinw@codeaurora.org>
Subject: Re: [PATCH 1/2] pwm: Add different PWM output types support
Date: Sat, 18 Sep 2021 13:18:23 +0200 [thread overview]
Message-ID: <YUXK/4/1uYBjJt7S@kroah.com> (raw)
In-Reply-To: <1568415464-20267-1-git-send-email-gurus@codeaurora.org>
On Fri, Sep 13, 2019 at 03:57:43PM -0700, Guru Das Srinagesh wrote:
> From: Fenglin Wu <fenglinw@codeaurora.org>
>
> Normally, PWM channel has fixed output until software request to change
> its settings. There are some PWM devices which their outputs could be
> changed autonomously according to a predefined pattern programmed in
> hardware. Add pwm_output_type enum type to identify these two different
> PWM types and add relevant helper functions to set and get PWM output
> types and pattern.
>
> Change-Id: Ia1f914a45ab4f4dd7be037a395eeb89d0e65a80e
This is not needed an a upstream patch, checkpatch should have told you
:(
> Signed-off-by: Fenglin Wu <fenglinw@codeaurora.org>
> Signed-off-by: Guru Das Srinagesh <gurus@codeaurora.org>
> ---
> drivers/pwm/core.c | 26 ++++++++++++++++++++
> drivers/pwm/sysfs.c | 50 ++++++++++++++++++++++++++++++++++++++
You forgot a Documentation/ABI/ update for your new sysfs file :(
thanks,
greg k-h
prev parent reply other threads:[~2021-09-18 11:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-13 22:57 [PATCH 1/2] pwm: Add different PWM output types support Guru Das Srinagesh
2019-09-13 22:57 ` [PATCH 2/2] pwm: core: Add option to config PWM duty/period with u64 data length Guru Das Srinagesh
2019-09-16 13:59 ` kbuild test robot
2019-09-16 14:00 ` Thierry Reding
2019-09-16 14:07 ` kbuild test robot
2019-09-16 14:01 ` [PATCH 1/2] pwm: Add different PWM output types support Thierry Reding
2019-09-24 5:43 ` Guru Das Srinagesh
2019-09-24 6:39 ` Uwe Kleine-König
2019-09-24 10:46 ` Thierry Reding
2019-09-16 18:25 ` Uwe Kleine-König
2019-09-24 6:01 ` Guru Das Srinagesh
2021-09-18 11:18 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUXK/4/1uYBjJt7S@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=fenglinw@codeaurora.org \
--cc=gurus@codeaurora.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=salyzyn@google.com \
--cc=sspatil@google.com \
--cc=subbaram@codeaurora.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox