[PATCH] pwm: atmel-tcp: Make atmel_tcb_divisors static

[PATCH] pwm: atmel-tcp: Make atmel_tcb_divisors static

[Uwe Kleine-König]

The array atmel_tcb_divisors is not supposed to be used outside of the
driver, so make it static.

This fixes a sparse warning:

	drivers/pwm/pwm-atmel-tcb.c:64:10: warning: symbol 'atmel_tcb_divisors' was not declared. Should it be static?

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 drivers/pwm/pwm-atmel-tcb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pwm/pwm-atmel-tcb.c b/drivers/pwm/pwm-atmel-tcb.c
index 36f7ea381838..9869d3eb8355 100644
--- a/drivers/pwm/pwm-atmel-tcb.c
+++ b/drivers/pwm/pwm-atmel-tcb.c
@@ -61,7 +61,7 @@ struct atmel_tcb_pwm_chip {
 	struct atmel_tcb_channel bkup;
 };
 
-const u8 atmel_tcb_divisors[] = { 2, 8, 32, 128, 0, };
+static const u8 atmel_tcb_divisors[] = { 2, 8, 32, 128, 0, };
 
 static inline struct atmel_tcb_pwm_chip *to_tcb_chip(struct pwm_chip *chip)
 {

base-commit: 3123109284176b1532874591f7c81f3837bbdc17
-- 
2.35.1

Re: [PATCH] pwm: atmel-tcp: Make atmel_tcb_divisors static

[Uwe Kleine-König]

[-- Attachment #1: Type: text/plain, Size: 322 bytes --]

Hello Thierry,

I fat fingered the driver name in the subject line. Iff you apply this 
patch please fixup accordingly (i.e. s/tcp/tcb/).

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] pwm: atmel-tcp: Make atmel_tcb_divisors static

[Claudiu.Beznea]

On 08.04.2022 18:29, Uwe Kleine-König wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> The array atmel_tcb_divisors is not supposed to be used outside of the
> driver, so make it static.
> 
> This fixes a sparse warning:
> 
>         drivers/pwm/pwm-atmel-tcb.c:64:10: warning: symbol 'atmel_tcb_divisors' was not declared. Should it be static?
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>


> ---
>  drivers/pwm/pwm-atmel-tcb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pwm/pwm-atmel-tcb.c b/drivers/pwm/pwm-atmel-tcb.c
> index 36f7ea381838..9869d3eb8355 100644
> --- a/drivers/pwm/pwm-atmel-tcb.c
> +++ b/drivers/pwm/pwm-atmel-tcb.c
> @@ -61,7 +61,7 @@ struct atmel_tcb_pwm_chip {
>         struct atmel_tcb_channel bkup;
>  };
> 
> -const u8 atmel_tcb_divisors[] = { 2, 8, 32, 128, 0, };
> +static const u8 atmel_tcb_divisors[] = { 2, 8, 32, 128, 0, };
> 
>  static inline struct atmel_tcb_pwm_chip *to_tcb_chip(struct pwm_chip *chip)
>  {
> 
> base-commit: 3123109284176b1532874591f7c81f3837bbdc17
> --
> 2.35.1
> 

Re: [PATCH] pwm: atmel-tcp: Make atmel_tcb_divisors static

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 554 bytes --]

On Fri, Apr 08, 2022 at 05:29:10PM +0200, Uwe Kleine-König wrote:
> The array atmel_tcb_divisors is not supposed to be used outside of the
> driver, so make it static.
> 
> This fixes a sparse warning:
> 
> 	drivers/pwm/pwm-atmel-tcb.c:64:10: warning: symbol 'atmel_tcb_divisors' was not declared. Should it be static?
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  drivers/pwm/pwm-atmel-tcb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied with the subject fixed up.

Thanks,
Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]