From: Thierry Reding <thierry.reding@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Lee Jones <lee.jones@linaro.org>,
Nicolas Saenz Julienne <nsaenz@kernel.org>,
linux-pwm@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH] pwm: raspberrypi-poe: Fix endianess in firmware struct
Date: Fri, 22 Apr 2022 18:51:45 +0200 [thread overview]
Message-ID: <YmLdIUoeIgGgwkT6@orome> (raw)
In-Reply-To: <20220408153846.172701-1-u.kleine-koenig@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 896 bytes --]
On Fri, Apr 08, 2022 at 05:38:46PM +0200, Uwe Kleine-König wrote:
> The reg member of struct raspberrypi_pwm_prop is a little endian 32 bit
> quantity. Explicitly convert the (native endian) value to little endian
> on assignment as is already done in raspberrypi_pwm_set_property().
>
> This fixes the following sparse warning:
>
> drivers/pwm/pwm-raspberrypi-poe.c:69:24: warning: incorrect type in initializer (different base types)
> drivers/pwm/pwm-raspberrypi-poe.c:69:24: expected restricted __le32 [usertype] reg
> drivers/pwm/pwm-raspberrypi-poe.c:69:24: got unsigned int [usertype] reg
>
> Fixes: 79caa362eab6 ("pwm: Add Raspberry Pi Firmware based PWM bus")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/pwm/pwm-raspberrypi-poe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2022-04-22 16:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 15:38 [PATCH] pwm: raspberrypi-poe: Fix endianess in firmware struct Uwe Kleine-König
2022-04-22 16:51 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmLdIUoeIgGgwkT6@orome \
--to=thierry.reding@gmail.com \
--cc=kernel@pengutronix.de \
--cc=lee.jones@linaro.org \
--cc=linux-pwm@vger.kernel.org \
--cc=nsaenz@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox