From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB5A5C38145 for ; Wed, 7 Sep 2022 17:02:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229730AbiIGRCM (ORCPT ); Wed, 7 Sep 2022 13:02:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229706AbiIGRCF (ORCPT ); Wed, 7 Sep 2022 13:02:05 -0400 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D57DB275A; Wed, 7 Sep 2022 10:01:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662570119; x=1694106119; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=m8q1cRyJn4QGSaHSkQWRLJ2c+Tc4QSATGJwzbx5HRMc=; b=AoCVAg3qONK/5ylWuH5vEB3VJqWOFmZ5TJFNja/LeQi5TIkzguIQ/ETe uawkyS0GXrg7Fzlc9XWNemUZHBQgpOlAM+9AN2LM3K0JmonWwV9MV1D3G iugitvmRE8oyljiyCGVJkzcin/UNAcOSHcanYB8mJ9VAU41hYguoi9+kI PI/9QcIYhm5lC79sK4wD77mycFuhWMQRyQ9XT/fDdtxKdwTl+U5WpUAxO eYi94+7SYXEQjkVizAHqOApRMvFCGdZBM8NaQ9TCkHE3TTJYWWCB+fnqG 2H5BOKtcPbKW/iCoWzSO76Tlc/IORZw3ziC+YOVbjSTAgMW1hU0XFm2EW A==; X-IronPort-AV: E=McAfee;i="6500,9779,10463"; a="360903181" X-IronPort-AV: E=Sophos;i="5.93,297,1654585200"; d="scan'208";a="360903181" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2022 10:00:46 -0700 X-IronPort-AV: E=Sophos;i="5.93,297,1654585200"; d="scan'208";a="682893714" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2022 10:00:44 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1oVyPq-009jHI-1W; Wed, 07 Sep 2022 20:00:42 +0300 Date: Wed, 7 Sep 2022 20:00:42 +0300 From: Andy Shevchenko To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, Thierry Reding Subject: Re: [PATCH v1 2/9] pwm: lpss: Move exported symbols to PWM_LPSS namespace Message-ID: References: <20220906195735.87361-1-andriy.shevchenko@linux.intel.com> <20220906195735.87361-2-andriy.shevchenko@linux.intel.com> <20220907091144.picr3byckxco7w6m@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org On Wed, Sep 07, 2022 at 05:21:53PM +0300, Andy Shevchenko wrote: > On Wed, Sep 07, 2022 at 11:11:44AM +0200, Uwe Kleine-König wrote: > > On Tue, Sep 06, 2022 at 10:57:28PM +0300, Andy Shevchenko wrote: ... > > > -EXPORT_SYMBOL_GPL(pwm_lpss_probe); > > > +EXPORT_SYMBOL_NS_GPL(pwm_lpss_probe, PWM_LPSS); > > > > There is something possible with more magic: > > #define DEFAULT_SYMBOL_NAMESPACE PWM_LPSS > > > > which you only need once in pwm-lpss.c and then all exports use that > > namespace. (And if you pick up my suggestion for patch 1 you also > > benefit from that.) > > For a single export (even for a few of them) it's an overkill. Ah, you adding there 4 more. But still I think it's an overkill. It's so small driver that duplicating namespace in each of the exported symbols is not an issue, is it? -- With Best Regards, Andy Shevchenko