From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
Cc: linux-pwm@vger.kernel.org, "Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH 2/2] pwm: lpss: Define DEFAULT_SYMBOL_NAMESPACE earlier
Date: Tue, 3 Dec 2024 21:19:58 +0200 [thread overview]
Message-ID: <Z09Z3oVCrtv-IZUz@smile.fi.intel.com> (raw)
In-Reply-To: <9f0e30c514a846aec72655a52deaed276467a07e.1733245406.git.ukleinek@kernel.org>
On Tue, Dec 03, 2024 at 06:16:15PM +0100, Uwe Kleine-König wrote:
> DEFAULT_SYMBOL_NAMESPACE must be already defined when <linux/export.h>
> is included. So move the define above the include block.
>
> With the DEFAULT_SYMBOL_NAMESPACE being defined too late, the exported
> symbols end up in the default namespace. So the modules making use of
> the symbols defined in pwm-lpss.c can import these just fine and just
> import the the PWM_LPSS namespace without any gain.
Documentation disagrees with you. But, you are right, a lurking bug is here as
we need to undef existing define.
> -#define DEFAULT_SYMBOL_NAMESPACE PWM_LPSS
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2024-12-03 19:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-03 17:16 [PATCH 0/2] pwm: lpss: module namespace fixes Uwe Kleine-König
2024-12-03 17:16 ` [PATCH 1/2] pwm: lpss: Move namespace import into a header Uwe Kleine-König
2024-12-03 19:12 ` Andy Shevchenko
2024-12-03 21:32 ` Uwe Kleine-König
2024-12-03 22:28 ` Andy Shevchenko
2024-12-03 23:38 ` Uwe Kleine-König
2024-12-04 1:50 ` Andy Shevchenko
2024-12-16 8:46 ` Uwe Kleine-König
2025-01-21 22:46 ` Linus Walleij
2024-12-03 17:16 ` [PATCH 2/2] pwm: lpss: Define DEFAULT_SYMBOL_NAMESPACE earlier Uwe Kleine-König
2024-12-03 19:19 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z09Z3oVCrtv-IZUz@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-pwm@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox