From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F46C1FC0F0 for ; Tue, 4 Mar 2025 08:41:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741077704; cv=none; b=MTLY3lissvRegkkkkKZ6p1QYUlrWgAZCp3cq7MZI/68qf20qxFUadhd71wGjwFOJEVLLN7cg8al96Q5JAgvnUXXO1Zcg2Eq3CZe3CXq+1klaCju4YgVeXimbx+OPiwbV8JKVdEIL7Sa2uhBiJpt/l1+VUdXU0J7jG2slK4Vdf5w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741077704; c=relaxed/simple; bh=dQMWqa7bqGUsuYvK1/Ia2Th2yYYxZTfZ4zTTgbD3dM8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=B4d/hviwO/9AUoj3ysXjHwKV8/YLXd/Y+L6ztaxGduTqgp35MU+Ha++ZG+ckrltXyOZ+58x3Qa8+AFN/W1FAyHwSW+ppQXSy/MQO0wg3eLJFyDWfy4jh9moRfcBwyaA5bLqPnZAm9gaWNQj2mpLYYnjFsVzCf8ILs/FbdbwVLP4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=mETPgI23; arc=none smtp.client-ip=209.85.218.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mETPgI23" Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-abf4b376f2fso499682266b.3 for ; Tue, 04 Mar 2025 00:41:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741077701; x=1741682501; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=56LRZhimeVf0548v2DjrELpnYIUuGBcJG2m3Hu8yBtw=; b=mETPgI23iMZxrX7GFlSZRwwi7jXMWbtYR4M3vRphfBCECl58WfB81Rx9vB6ka0K3t2 L/LFUswCMPP7zQsX2+qYYyvXJlIFe0+96ZuZB8QIMW20xuVvEn+22VTPPwE1ykFp8UET QugvwKbKib9yg5nXJnasC8WWRhvPtotg0o5LLcT2L7QDr4n/HgpZlFourgonBQLEcyHz 41qc2oNbkw5hA/ZW/Afs2EeB6X3vq1X7y8SunsRQFmSsV8LSHWEd8ogu72H0yiamGsVk 8v6oVEFyYisedodPQ4g7etioVcdXT7oFxC3SNWy+UxjDNYvR6ytzHziVV9qqpUhDN4/i ShJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741077701; x=1741682501; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=56LRZhimeVf0548v2DjrELpnYIUuGBcJG2m3Hu8yBtw=; b=n7Uy7F7xnGtD4wvPjrgxBaH1WulzfqfFG8LEGqaoph8KKZ6tbsFKfzZ0cfMM/dEM3f Hq2J1cx6mtUQvRmVrVaD0/hnRnjKmUp0424sokdRra5AU76fUOnMXlGH+jd0zYJatVKB 7VLjcMbybM2YshpQSE+OXEAUJNlhdhv8YcjsPlHf41A3ru7L5bZwg3nH9bFU+yfy9Hwv 85gPcrW9C7mCtRlcalRS/iYAVVlkdNQD/8z8dzdJGRlvEU8GSSDRV59Rpd+DnG0kLjSI 9e24swAO+QDzPLTIULH48Xcfth6rZgag1e3y+DEtJp1XCjduUZpIspAMaPVxkL2bWs9L uv9w== X-Forwarded-Encrypted: i=1; AJvYcCVaJ8F8MISSelm3Iow8bmkY6x0GFX9G56ITyR9K1lZs+R4fxJhk3Zrr8Vzi5E5QhzgrhSPH9G509uc=@vger.kernel.org X-Gm-Message-State: AOJu0YzATtq6AGIOrSvoPSPDDRUlvqnjwWAPISOpmXekP6zfNs1t8xsn LvTwYjlSmc9sedvtlGcDAVyfGVPjf7NP2CyRYrOlqIpyIO7oEBlBHmF7VK4eqKw= X-Gm-Gg: ASbGncvtAyT13GQ+HyK6iTc/gtMU5NBYAZgleztif2lgWESq0YcA0l3+Oe06sFFOmow yFMi/JpSeWdCZJ61m1Dgrfc4ofhrwMFpemnA8m0xI4u3hpUWlkp+2vY3aJ5rTHMeGjVkIHa95Ua fZsXHaY12tbU5qYh/Nayd9IUAW1yBSB3ogTBhzch7Dws2Wijn4PF7/ONz4fJ4MD1N5iWdlUlSKU vVMa55srAglertckW8jg4iO7+JvIiU7GjjtCB02IwIgu1CWPfOpmJFzx8XDgvNaeIMcETWj7Iv6 tY7ZzYCoPbpjuPnGyXLSaJ0ouKaKxmh+nmc8CYZnHg== X-Google-Smtp-Source: AGHT+IFFHM/nljeEtmfpwAYQ5fCe3mzYlZ/kbhPchbUbj2wuqBNp/7U42a+daD7qurHBY27yA6v3Yg== X-Received: by 2002:a17:907:7d89:b0:abf:7832:bf5 with SMTP id a640c23a62f3a-abf783244f6mr732543466b.34.1741077700633; Tue, 04 Mar 2025 00:41:40 -0800 (PST) Received: from linaro.org ([62.231.96.41]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abf529feacfsm557445466b.153.2025.03.04.00.41.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 00:41:40 -0800 (PST) Date: Tue, 4 Mar 2025 10:41:38 +0200 From: Abel Vesa To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Lee Jones , Pavel Machek , Anjelique Melendez , Kamal Wadhwa , Jishnu Prakash , Bjorn Andersson , Konrad Dybcio , Johan Hovold , Sebastian Reichel , Pavel Machek , linux-leds@vger.kernel.org, linux-pwm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v3 0/3] leds: rgb: leds-qcom-lpg: PWM fixes Message-ID: References: <20250303-leds-qcom-lpg-fix-max-pwm-on-hi-res-v3-0-62703c0ab76a@linaro.org> Precedence: bulk X-Mailing-List: linux-pwm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On 25-03-04 07:29:46, Uwe Kleine-König wrote: > Hello, > > On Mon, Mar 03, 2025 at 01:52:49PM +0200, Abel Vesa wrote: > > The PWM allow configuring the PWM resolution from 8 bits PWM > > values up to 15 bits values, for the Hi-Res PWMs, and then either > > 6-bit or 9-bit for the normal PWMs. The current implementation loops > > through all possible resolutions (PWM sizes), for the PWM subtype, on top > > of the already existing process of determining the prediv, exponent and > > refclk. > > > > The first and second issues are related to capping the computed PWM > > value. > > I just took a very quick look. I'd say squash the first and second patch > into a single one. Splitting a change that fixes the same issue in the > two branches of an if condition has no benefit. Actually, the first two patches fix different commits. The first patch fixes a commit that is only in linux-next for now, while the second patch fixes a commit that has been merged in 6.4. So they need to be separate patches. > > Other than that this patch set would also benefit from what I wrote in > the review of the other patch you send: Please mention a request where > the result becomes wrong. This considerably simplifies understanding > your changes. Sure. Will describe the 5ms vs 4.26ms period scenario. Hope that's OK. > > Thanks > Uwe Thanks for reviewing, Abel