From: Jeff LaBundy <jeff@labundy.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Munehisa Kamata <kamatam@amazon.com>,
linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH 3/4] pwm: iqs620a: Explicitly set .polarity in .get_state()
Date: Fri, 10 Mar 2023 17:29:07 -0600 [thread overview]
Message-ID: <ZAu9Q9gfkJwM3szn@nixie71> (raw)
In-Reply-To: <20230310184815.x5v2ysyeyshnapm5@pengutronix.de>
On Fri, Mar 10, 2023 at 07:48:15PM +0100, Uwe Kleine-König wrote:
> [To += Jeff LaBundy]
>
> On Tue, Feb 28, 2023 at 02:55:07PM +0100, Uwe Kleine-König wrote:
> > The driver only supports normal polarity. Complete the implementation of
> > .get_state() by setting .polarity accordingly.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
> I think we should apply this patch as a fix to prevent similar failures
> as reported for the meson driver. To justify that:
>
> Fixes: 6f0841a8197b ("pwm: Add support for Azoteq IQS620A PWM generator")
Reviewed-by: Jeff LaBundy <jeff@labundy.com>
>
> Best regards
> Uwe
>
> --
> Pengutronix e.K. | Uwe Kleine-König |
> Industrial Linux Solutions | https://www.pengutronix.de/ |
next prev parent reply other threads:[~2023-03-10 23:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-28 13:55 [PATCH 0/4] pwm: Ensure .polarity is set in .get_state() Uwe Kleine-König
2023-02-28 13:55 ` [PATCH 1/4] pwm: hibvt: Explicitly set .polarity " Uwe Kleine-König
2023-03-10 18:59 ` Uwe Kleine-König
2023-02-28 13:55 ` [PATCH 2/4] pwm: cros-ec: " Uwe Kleine-König
2023-02-28 16:19 ` Guenter Roeck
2023-03-10 18:50 ` Uwe Kleine-König
2023-02-28 13:55 ` [PATCH 3/4] pwm: iqs620a: " Uwe Kleine-König
2023-03-10 18:48 ` Uwe Kleine-König
2023-03-10 23:29 ` Jeff LaBundy [this message]
2023-02-28 13:55 ` [PATCH 4/4] pwm: sprd: " Uwe Kleine-König
2023-03-10 18:43 ` Uwe Kleine-König
2023-05-08 3:45 ` [PATCH 0/4] pwm: Ensure .polarity is set " patchwork-bot+chrome-platform
2023-05-08 3:56 ` patchwork-bot+chrome-platform
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAu9Q9gfkJwM3szn@nixie71 \
--to=jeff@labundy.com \
--cc=kamatam@amazon.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox