Re: [PATCH 7/8] pwm: cros-ec: Put per channel data into driver data

[Tzung-Bi Shih <tzungbi@kernel.org>]

On Thu, Jun 29, 2023 at 11:48:38AM +0200, Uwe Kleine-König wrote:
> Instead of an allocation of a single u16 per channel, allocate them all
> in a single chunk which greatly reduces memory fragmentation and also
> the overhead to track the allocated memory. Also put the channel data in
> driver data where it's cheaper to determine the address (no function
> call involved, just a trivial pointer addition).
> 
> This also allows to get rid of the request and free callbacks.
> 
> The only cost is that the channel data is allocated early, and even for
> unused channels.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

With comments addressed below:
Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>

> @@ -27,6 +27,7 @@ struct cros_ec_pwm_device {
>  	struct cros_ec_device *ec;
>  	struct pwm_chip chip;
>  	bool use_pwm_type;
> +	struct cros_ec_pwm *channel;

Please update the kernel-doc too.  Otherwise:
$ ./scripts/kernel-doc -none drivers/pwm/pwm-cros-ec.c
drivers/pwm/pwm-cros-ec.c:31: warning: Function parameter or member 'channel'
not described in 'cros_ec_pwm_device'

I have no strong preference: please consider to use `channels` if it makes
sense.