From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AA48C7115A for ; Fri, 18 Aug 2023 15:01:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377949AbjHRPAi (ORCPT ); Fri, 18 Aug 2023 11:00:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47330 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377953AbjHRPAc (ORCPT ); Fri, 18 Aug 2023 11:00:32 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1FD80CD; Fri, 18 Aug 2023 08:00:30 -0700 (PDT) X-IronPort-AV: E=McAfee;i="6600,9927,10806"; a="404099784" X-IronPort-AV: E=Sophos;i="6.01,183,1684825200"; d="scan'208";a="404099784" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Aug 2023 08:00:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10806"; a="764582797" X-IronPort-AV: E=Sophos;i="6.01,183,1684825200"; d="scan'208";a="764582797" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga008.jf.intel.com with ESMTP; 18 Aug 2023 08:00:25 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qX0xa-00CvAx-2G; Fri, 18 Aug 2023 18:00:22 +0300 Date: Fri, 18 Aug 2023 18:00:22 +0300 From: Andy Shevchenko To: Li Zetao Cc: linus.walleij@linaro.org, brgl@bgdev.pl, j-keerthy@ti.com, vz@mleia.com, thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de, grygorii.strashko@ti.com, ssantosh@kernel.org, khilman@kernel.org, shubhrajyoti.datta@amd.com, srinivas.neeli@amd.com, michal.simek@amd.com, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH -next 08/11] gpio: omap: Use helper function devm_clk_get_prepared() Message-ID: References: <20230818093018.1051434-1-lizetao1@huawei.com> <20230818093018.1051434-9-lizetao1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230818093018.1051434-9-lizetao1@huawei.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org On Fri, Aug 18, 2023 at 05:30:15PM +0800, Li Zetao wrote: > Since commit 7ef9651e9792 ("clk: Provide new devm_clk helpers for > prepared and enabled clocks"), devm_clk_get() and clk_prepare() can now be > replaced by devm_clk_get_prepared() when the driver enables (and possibly > prepares) the clocks for the whole lifetime of the device. Moreover, it is > no longer necessary to unprepare and disable the clocks explicitly. The commit message isn't correct. Seems you copied'n'pasted from other cases. Please, revisit. Code wise looks legit to me. With the commit message fixed Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko