From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBC03C7115A for ; Fri, 18 Aug 2023 15:12:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378013AbjHRPL7 (ORCPT ); Fri, 18 Aug 2023 11:11:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34356 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378049AbjHRPLt (ORCPT ); Fri, 18 Aug 2023 11:11:49 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B7764224; Fri, 18 Aug 2023 08:11:34 -0700 (PDT) X-IronPort-AV: E=McAfee;i="6600,9927,10806"; a="358092534" X-IronPort-AV: E=Sophos;i="6.01,183,1684825200"; d="scan'208";a="358092534" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Aug 2023 08:11:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10806"; a="825143806" X-IronPort-AV: E=Sophos;i="6.01,183,1684825200"; d="scan'208";a="825143806" Received: from smile.fi.intel.com ([10.237.72.54]) by FMSMGA003.fm.intel.com with ESMTP; 18 Aug 2023 08:11:19 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qX189-00DI9l-1A; Fri, 18 Aug 2023 18:11:17 +0300 Date: Fri, 18 Aug 2023 18:11:17 +0300 From: Andy Shevchenko To: Li Zetao Cc: linus.walleij@linaro.org, brgl@bgdev.pl, j-keerthy@ti.com, vz@mleia.com, thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de, grygorii.strashko@ti.com, ssantosh@kernel.org, khilman@kernel.org, shubhrajyoti.datta@amd.com, srinivas.neeli@amd.com, michal.simek@amd.com, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH -next 09/11] gpio: stp-xway: Use helper function devm_clk_get_enabled() Message-ID: References: <20230818093018.1051434-1-lizetao1@huawei.com> <20230818093018.1051434-10-lizetao1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230818093018.1051434-10-lizetao1@huawei.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org On Fri, Aug 18, 2023 at 05:30:16PM +0800, Li Zetao wrote: > Since commit 7ef9651e9792 ("clk: Provide new devm_clk helpers for > prepared and enabled clocks"), devm_clk_get() and clk_prepare_enable() > can now be replaced by devm_clk_get_enabled() when the driver enables > (and possibly prepares) the clocks for the whole lifetime of the device. > Moreover, it is no longer necessary to unprepare and disable the clocks > explicitly. ... > ret = devm_gpiochip_add_data(&pdev->dev, &chip->gc, chip); > - if (ret) { > - clk_disable_unprepare(clk); > + if (ret) > return ret; > - } > > dev_info(&pdev->dev, "Init done\n"); Go further and simply return devm_gpiochip_add_data(...); -- With Best Regards, Andy Shevchenko