From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F327C7115C for ; Fri, 18 Aug 2023 15:13:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358801AbjHRPND (ORCPT ); Fri, 18 Aug 2023 11:13:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378108AbjHRPMv (ORCPT ); Fri, 18 Aug 2023 11:12:51 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C65C4229; Fri, 18 Aug 2023 08:12:41 -0700 (PDT) X-IronPort-AV: E=McAfee;i="6600,9927,10806"; a="358092944" X-IronPort-AV: E=Sophos;i="6.01,183,1684825200"; d="scan'208";a="358092944" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Aug 2023 08:12:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10806"; a="728628189" X-IronPort-AV: E=Sophos;i="6.01,183,1684825200"; d="scan'208";a="728628189" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga007.jf.intel.com with ESMTP; 18 Aug 2023 08:12:36 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qX19N-00DKtf-2M; Fri, 18 Aug 2023 18:12:33 +0300 Date: Fri, 18 Aug 2023 18:12:33 +0300 From: Andy Shevchenko To: Li Zetao Cc: linus.walleij@linaro.org, brgl@bgdev.pl, j-keerthy@ti.com, vz@mleia.com, thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de, grygorii.strashko@ti.com, ssantosh@kernel.org, khilman@kernel.org, shubhrajyoti.datta@amd.com, srinivas.neeli@amd.com, michal.simek@amd.com, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH -next 10/11] gpio: xilinx: Use helper function devm_clk_get_optional_enabled() Message-ID: References: <20230818093018.1051434-1-lizetao1@huawei.com> <20230818093018.1051434-11-lizetao1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230818093018.1051434-11-lizetao1@huawei.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org On Fri, Aug 18, 2023 at 05:30:17PM +0800, Li Zetao wrote: > Since commit 7ef9651e9792 ("clk: Provide new devm_clk helpers for > prepared and enabled clocks"), devm_clk_get_optional() and > clk_prepare_enable() can now be replaced by > devm_clk_get_optional_enabled() when the driver enables (and possibly > prepares) the clocks for the whole lifetime of the device. Moreover, > it is no longer necessary to unprepare and disable the clocks explicitly. ... > if (IS_ERR(chip->clk)) > - return dev_err_probe(&pdev->dev, PTR_ERR(chip->clk), "input clock not found.\n"); > + return dev_err_probe(&pdev->dev, PTR_ERR(chip->clk), > + "input clock not found or failed to prepare clk\n"); Don't alter message in this change. ... Do you need to set driver data now? -- With Best Regards, Andy Shevchenko