[PATCH v1 0/2] LPSS PWM cleanups

[PATCH v1 0/2] LPSS PWM cleanups

[Raag Jadav]

This series implements minor cleanups for LPSS PWM driver.

Raag Jadav (2):
  pwm: lpss: use devm_pm_runtime_enable() helper
  pwm: lpss: drop redundant runtime PM handles

 drivers/pwm/pwm-lpss-pci.c      | 22 ----------------------
 drivers/pwm/pwm-lpss-platform.c | 10 +---------
 2 files changed, 1 insertion(+), 31 deletions(-)

-- 
2.35.3

[PATCH v1 1/2] pwm: lpss: use devm_pm_runtime_enable() helper

[Raag Jadav]

Use devm_pm_runtime_enable() helper to enable runtime PM and drop redundant
platform ->remove() callback.

Signed-off-by: Raag Jadav <raag.jadav@intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/pwm/pwm-lpss-platform.c | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/drivers/pwm/pwm-lpss-platform.c b/drivers/pwm/pwm-lpss-platform.c
index 319809aac2c4..60b376393352 100644
--- a/drivers/pwm/pwm-lpss-platform.c
+++ b/drivers/pwm/pwm-lpss-platform.c
@@ -57,14 +57,7 @@ static int pwm_lpss_probe_platform(struct platform_device *pdev)
 						    DPM_FLAG_SMART_SUSPEND);
 
 	pm_runtime_set_active(&pdev->dev);
-	pm_runtime_enable(&pdev->dev);
-
-	return 0;
-}
-
-static void pwm_lpss_remove_platform(struct platform_device *pdev)
-{
-	pm_runtime_disable(&pdev->dev);
+	return devm_pm_runtime_enable(&pdev->dev);
 }
 
 static const struct acpi_device_id pwm_lpss_acpi_match[] = {
@@ -82,7 +75,6 @@ static struct platform_driver pwm_lpss_driver_platform = {
 		.acpi_match_table = pwm_lpss_acpi_match,
 	},
 	.probe = pwm_lpss_probe_platform,
-	.remove_new = pwm_lpss_remove_platform,
 };
 module_platform_driver(pwm_lpss_driver_platform);
 
-- 
2.35.3

[PATCH v1 2/2] pwm: lpss: drop redundant runtime PM handles

[Raag Jadav]

We no longer need empty runtime PM handles for PCI devices after commit
c5eb1190074c ("PCI / PM: Allow runtime PM without callback functions").
Drop them and let PCI core take care of power state transitions.

Signed-off-by: Raag Jadav <raag.jadav@intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/pwm/pwm-lpss-pci.c | 22 ----------------------
 1 file changed, 22 deletions(-)

diff --git a/drivers/pwm/pwm-lpss-pci.c b/drivers/pwm/pwm-lpss-pci.c
index b4134bee2863..51efe37e23fe 100644
--- a/drivers/pwm/pwm-lpss-pci.c
+++ b/drivers/pwm/pwm-lpss-pci.c
@@ -48,25 +48,6 @@ static void pwm_lpss_remove_pci(struct pci_dev *pdev)
 	pm_runtime_get_sync(&pdev->dev);
 }
 
-static int pwm_lpss_runtime_suspend_pci(struct device *dev)
-{
-	/*
-	 * The PCI core will handle transition to D3 automatically. We only
-	 * need to provide runtime PM hooks for that to happen.
-	 */
-	return 0;
-}
-
-static int pwm_lpss_runtime_resume_pci(struct device *dev)
-{
-	return 0;
-}
-
-static DEFINE_RUNTIME_DEV_PM_OPS(pwm_lpss_pci_pm,
-				 pwm_lpss_runtime_suspend_pci,
-				 pwm_lpss_runtime_resume_pci,
-				 NULL);
-
 static const struct pci_device_id pwm_lpss_pci_ids[] = {
 	{ PCI_VDEVICE(INTEL, 0x0ac8), (unsigned long)&pwm_lpss_bxt_info},
 	{ PCI_VDEVICE(INTEL, 0x0f08), (unsigned long)&pwm_lpss_byt_info},
@@ -86,9 +67,6 @@ static struct pci_driver pwm_lpss_driver_pci = {
 	.id_table = pwm_lpss_pci_ids,
 	.probe = pwm_lpss_probe_pci,
 	.remove = pwm_lpss_remove_pci,
-	.driver = {
-		.pm = pm_ptr(&pwm_lpss_pci_pm),
-	},
 };
 module_pci_driver(pwm_lpss_driver_pci);
 
-- 
2.35.3

Re: [PATCH v1 0/2] LPSS PWM cleanups

[Uwe Kleine-König]

[-- Attachment #1: Type: text/plain, Size: 698 bytes --]

Hello,

On Mon, Feb 12, 2024 at 11:40:35AM +0530, Raag Jadav wrote:
> This series implements minor cleanups for LPSS PWM driver.
> 
> Raag Jadav (2):
>   pwm: lpss: use devm_pm_runtime_enable() helper
>   pwm: lpss: drop redundant runtime PM handles
> 
>  drivers/pwm/pwm-lpss-pci.c      | 22 ----------------------
>  drivers/pwm/pwm-lpss-platform.c | 10 +---------
>  2 files changed, 1 insertion(+), 31 deletions(-)

the series looks fine to me. Will give others some more time to comment
and apply later.

Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH v1 2/2] pwm: lpss: drop redundant runtime PM handles

[Jarkko Nikula]

On 2/12/24 08:10, Raag Jadav wrote:
> We no longer need empty runtime PM handles for PCI devices after commit
> c5eb1190074c ("PCI / PM: Allow runtime PM without callback functions").
> Drop them and let PCI core take care of power state transitions.
> 
> Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>   drivers/pwm/pwm-lpss-pci.c | 22 ----------------------
>   1 file changed, 22 deletions(-)
> 
Will this patch cause a regression if applied without your another patch 
to the drivers/pci/pci-driver.c?

https://lore.kernel.org/linux-pci/20240212063233.5599-1-raag.jadav@intel.com/

Re: [PATCH v1 2/2] pwm: lpss: drop redundant runtime PM handles

[Raag Jadav]

On Wed, Feb 14, 2024 at 09:04:09AM +0200, Jarkko Nikula wrote:
> On 2/12/24 08:10, Raag Jadav wrote:
> > We no longer need empty runtime PM handles for PCI devices after commit
> > c5eb1190074c ("PCI / PM: Allow runtime PM without callback functions").
> > Drop them and let PCI core take care of power state transitions.
> > 
> > Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> >   drivers/pwm/pwm-lpss-pci.c | 22 ----------------------
> >   1 file changed, 22 deletions(-)
> > 
> Will this patch cause a regression if applied without your another patch to
> the drivers/pci/pci-driver.c?
> 
> https://lore.kernel.org/linux-pci/20240212063233.5599-1-raag.jadav@intel.com/

Yes, I'll send out a v2 with updated commit message after the PCI
one is accepted.

Raag