From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Raag Jadav <raag.jadav@intel.com>
Cc: u.kleine-koenig@pengutronix.de, jarkko.nikula@linux.intel.com,
mika.westerberg@linux.intel.com, linux-pwm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] pwm: dwc: allow suspend/resume for 16 channels
Date: Fri, 12 Apr 2024 19:45:48 +0300 [thread overview]
Message-ID: <ZhllPOXt41Ndlhc_@smile.fi.intel.com> (raw)
In-Reply-To: <ZhleDwUJLDEG5QwH@black.fi.intel.com>
On Fri, Apr 12, 2024 at 07:15:11PM +0300, Raag Jadav wrote:
> On Fri, Apr 12, 2024 at 06:35:51PM +0300, Andy Shevchenko wrote:
> > On Fri, Apr 12, 2024 at 11:38:12AM +0530, Raag Jadav wrote:
...
> > > + data = devm_kzalloc(dev, struct_size(data, chips, info->nr), GFP_KERNEL);
> > > + if (!data)
> > > + return dev_err_probe(dev, -ENOMEM, "Failed to allocate drvdata\n");
> >
> > Haven't noticed before, but we do not print messages for -ENOMEM. Just return
> > the code.
>
> Any special case for -ENOMEM?
Yes. But I have no link to the discussion at hand. Just believe me, or look into
Git history for changes that drop that messaging. Perhaps one or two will give a
hint where it starts from...
> I found a few drivers which still do.
They should be fixed.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2024-04-12 16:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 6:08 [PATCH v1] pwm: dwc: allow suspend/resume for 16 channels Raag Jadav
2024-04-12 11:12 ` Uwe Kleine-König
2024-04-12 15:32 ` Andy Shevchenko
2024-04-12 16:57 ` Uwe Kleine-König
2024-04-12 15:38 ` Raag Jadav
2024-04-12 15:45 ` Andy Shevchenko
2024-04-12 16:12 ` Raag Jadav
2024-04-12 15:35 ` Andy Shevchenko
2024-04-12 16:15 ` Raag Jadav
2024-04-12 16:45 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZhllPOXt41Ndlhc_@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=raag.jadav@intel.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox