From: Stanislav Jakubek <stano.jakubek@gmail.com>
To: laurent.pinchart@ideasonboard.com
Cc: brgl@bgdev.pl, conor+dt@kernel.org, devicetree@vger.kernel.org,
krzk+dt@kernel.org, lee@kernel.org, linus.walleij@linaro.org,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pwm@vger.kernel.org, robh@kernel.org, ukleinek@kernel.org
Subject: Re: [PATCH v4 1/4] dt-bindings: mfd: Add Analog Devices ADP5585
Date: Mon, 10 Jun 2024 08:21:09 +0200 [thread overview]
Message-ID: <ZmabVXaztPbp1ENV@standask-GA-A55M-S2HP> (raw)
In-Reply-To: <20240608141633.2562-2-laurent.pinchart@ideasonboard.com>
Hi Laurent,
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index 0a419453d183..91e62df4b296 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -39,10 +39,6 @@ properties:
> # AD5110 - Nonvolatile Digital Potentiometer
> - adi,ad5110
> # Analog Devices ADP5585 Keypad Decoder and I/O Expansion
> - - adi,adp5585
> - # Analog Devices ADP5585 Keypad Decoder and I/O Expansion with support for Row5
> - - adi,adp5585-02
> - # Analog Devices ADP5589 Keypad Decoder and I/O Expansion
> - adi,adp5589
> # Analog Devices LT7182S Dual Channel 6A, 20V PolyPhase Step-Down Silent Switcher
> - adi,lt7182s
seems like you removed the wrong comment here? With this, ADP5589 would have
a comment describing ADP5585.
Regards,
Stanislav
next prev parent reply other threads:[~2024-06-10 6:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-08 14:16 [PATCH v4 0/4] ADP5585 GPIO expander, PWM and keypad controller support Laurent Pinchart
2024-06-08 14:16 ` [PATCH v4 1/4] dt-bindings: mfd: Add Analog Devices ADP5585 Laurent Pinchart
2024-06-10 6:21 ` Stanislav Jakubek [this message]
2024-06-10 15:34 ` Laurent Pinchart
2024-06-08 14:16 ` [PATCH v4 2/4] mfd: adp5585: Add Analog Devices ADP5585 core support Laurent Pinchart
2024-06-10 15:11 ` Andy Shevchenko
2024-07-17 2:39 ` Frank Li
2024-07-19 7:36 ` Laurent Pinchart
2024-06-08 14:16 ` [PATCH v4 3/4] gpio: adp5585: Add Analog Devices ADP5585 support Laurent Pinchart
2024-06-10 15:15 ` Andy Shevchenko
2024-06-10 15:25 ` Laurent Pinchart
2024-06-10 16:29 ` Andy Shevchenko
2024-07-19 13:55 ` Laurent Pinchart
2024-08-01 23:15 ` Andy Shevchenko
2024-06-08 14:16 ` [PATCH v4 4/4] pwm: " Laurent Pinchart
2024-06-10 15:06 ` Andy Shevchenko
2024-06-10 15:28 ` Laurent Pinchart
2024-06-10 16:31 ` Andy Shevchenko
2024-07-19 14:07 ` Laurent Pinchart
2024-08-01 23:21 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZmabVXaztPbp1ENV@standask-GA-A55M-S2HP \
--to=stano.jakubek@gmail.com \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=robh@kernel.org \
--cc=ukleinek@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox