From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00D211D89F3; Tue, 15 Oct 2024 11:13:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.17 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728990839; cv=none; b=tBt25FFcAb3kpKGeNl85M2UuKhtJ7f3qXdOysO4Y/mzcIgst45Pdf2PVl77mGftlm40XklhGPRsCLp23sYA3NrXwwz/DEkmHi0o3fmiSOyOWBOe2S9zuFwNSA2p9End126zwdX5+g4wfQnJ0TIkzg4+wAhHh6oJYeLRhXvBIuHE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728990839; c=relaxed/simple; bh=WvOBu/y7FFpCn+M/r8vBiywVPF77IlJRf6ph7rkqysU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GrwwpctpXy+pIDkm4M/GRhBcqm1MH69/zplV7HE1eIGMEUEC6xD66xQ60DMDr2kUpDbddAdEw+rh0jc0GAT6CetRUD/6Guov4tqdHPBtMthh9zTinJA9bicFKDqeB/ISVuNnVwqai7rPL7wFf7VFjH08yo1VbDqlUfkjZVYWa94= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org; spf=fail smtp.mailfrom=kernel.org; arc=none smtp.client-ip=192.198.163.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=kernel.org X-CSE-ConnectionGUID: BKQ7Vu59SkmeIazDZCyYlA== X-CSE-MsgGUID: aOjOjgHgQCW52kdzqla80A== X-IronPort-AV: E=McAfee;i="6700,10204,11225"; a="28257774" X-IronPort-AV: E=Sophos;i="6.11,204,1725346800"; d="scan'208";a="28257774" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Oct 2024 04:13:51 -0700 X-CSE-ConnectionGUID: 0MXsz2toRPKXWw+85noTVQ== X-CSE-MsgGUID: HvfYLc6DTHCUipDyy5GClw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,204,1725346800"; d="scan'208";a="108654600" Received: from smile.fi.intel.com ([10.237.72.154]) by orviesa002.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Oct 2024 04:13:45 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1t0fUj-00000003FHF-0i05; Tue, 15 Oct 2024 14:13:41 +0300 Date: Tue, 15 Oct 2024 14:13:40 +0300 From: Andy Shevchenko To: David Lechner Cc: Antoniu Miclaus , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Nuno Sa , Olivier Moysan , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Marcelo Schmitt , Ivan Mikhaylov , Marius Cristea , Dumitru Ceclan , =?iso-8859-1?Q?Jo=E3o_Paulo_Gon=E7alves?= , Alisa-Dariana Roman , Mike Looijmans , AngeloGioacchino Del Regno , Sergiu Cuciurean , Dragos Bogdan , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org Subject: Re: [PATCH v3 6/6] iio: adc: ad4851: add ad485x driver Message-ID: References: <20241014094154.9439-1-antoniu.miclaus@analog.com> <20241014094154.9439-6-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-pwm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Mon, Oct 14, 2024 at 05:08:47PM -0500, David Lechner wrote: > On 10/14/24 8:14 AM, Andy Shevchenko wrote: > > On Mon, Oct 14, 2024 at 12:40:40PM +0300, Antoniu Miclaus wrote: ... > >> + return regmap_update_bits(st->regmap, AD4851_REG_PACKET, > >> + AD4851_PACKET_FORMAT_MASK, (osr == 1) ? 0 : 1); > > > > I would do it with a conditional > > > > if (osr ...) > > return regmap_update_bits(st->regmap, AD4851_REG_PACKET, > > AD4851_PACKET_FORMAT_MASK, 0); > > > > return regmap_update_bits(st->regmap, AD4851_REG_PACKET, > > AD4851_PACKET_FORMAT_MASK, 1); > > > If we do this, regmap_set_bits() and regmap_clear_bits() would > be even better. Sure, but I want also to have the only one conditional, so the respective helper functions can be easily read and followed. -- With Best Regards, Andy Shevchenko