public inbox for linux-pwm@vger.kernel.org
 help / color / mirror / Atom feed
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: "Krebs, Olaf" <Olaf.Krebs@emh-metering.com>
Cc: "Uwe Kleine-König" <ukleinek@kernel.org>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Fabio Estevam" <festevam@gmail.com>,
	"open list:PWM SUBSYSTEM" <linux-pwm@vger.kernel.org>,
	"open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
	<imx@lists.linux.dev>,
	"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
	<linux-arm-kernel@lists.infradead.org>,
	"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Fix IMX PWM period setting
Date: Thu, 30 Oct 2025 10:40:08 +0000	[thread overview]
Message-ID: <aQNAiDVKahkIrLYA@shell.armlinux.org.uk> (raw)
In-Reply-To: <c26fde7dff3a41ff9f7e6c97e2a31801@emh-metering.com>

On Thu, Oct 30, 2025 at 08:51:20AM +0000, Krebs, Olaf wrote:
> From: Olaf krebs <olaf.krebs@emh-metering.com>
> 
> We use 3 PWM channels to control an RGB LED. Without this patch we get an error:

Not build-tested.

> -		if (tpm->user_count > 1)
> +		if ((tpm->user_count > 1) && (tmp->real_period != 0))

"tmp" vs "tpm". As there's no variable called "tmp" in this function...

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

  reply	other threads:[~2025-10-30 10:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20251030084727.4098222-1-user@jenkins>
2025-10-30  8:51 ` [PATCH] Fix IMX PWM period setting Krebs, Olaf
2025-10-30 10:40   ` Russell King (Oracle) [this message]
     [not found] <20251030114641.4109598-1-user@jenkins>
2025-10-30 11:53 ` Krebs, Olaf
2025-10-30 17:13   ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aQNAiDVKahkIrLYA@shell.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=Olaf.Krebs@emh-metering.com \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=ukleinek@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox