From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D98FC3B5821 for ; Mon, 6 Jul 2026 10:39:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783334379; cv=none; b=duaKZEC+FlcawBhvjYB7Rw1gXeh9Boc5c41BD2yaEsdh0KPw5A9faUYFuYyZ929SDlaUZAOdgN83MKrvuvBvOhqM4DrxcbKBybqAi87AVhazzX0rzN+EaDlPDit0NpOuG3peLwd48F75KtBsk3JCKROL8vwy8o6kIzxrrCpdljs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783334379; c=relaxed/simple; bh=3NqyvZK6r61fTF0y4rbK6dX7OLUGCMSqOwp3B7dW+hA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BvW24YVTO8pWfi0Vtemnb955e7y6mlWPLo71stQO/EQvnQ1IyU5+sjJ8JE5nZ6/5vEprEPNWdbf4Edga4fKjuRrTtif1X0LJUw1ldUg4Qr5DEqzfsmYnTlkjcaIwxMvMv3TGlEePTxOXtycg/13/EO3aeWRWLje/eOEGoDLzvzA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=luQZ0p8N; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="luQZ0p8N" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-45fd464d51fso1436926f8f.3 for ; Mon, 06 Jul 2026 03:39:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1783334376; x=1783939176; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Go7lNGQE+yUmjPgVI2sZRhO3/S4lEXiftKalvVFj+z0=; b=luQZ0p8NTauewf+aSngxbrXRtTh855g1JE3Q7xVyTLOGrKSoZi/OE8dgP6akPCrxcl w7LsaKo1FEbNORHcJQtdm+KyWqn44tbf831ewTvNOkykaWOxY6EvMb2PG0fJchLhEk+q KBP8Oj9Z0uDjAiBCBS4aqaDRNx8g3Z0GA+T8xwh/USsOaYWN8iqoyHIFXNcXLbmsaMaw ncU/PMt3zaQdM/aPf4AtDRJZIqb0FRgUxx0j5YebvVABAiyKO6Ce5AvVPfLJrbu8hafD 9rQMLO8J/nuNt4qxd0D3m0mioezezAufGb5Fh3pSLxOrOy0rtHC4oyA9ihPX6+Z73+qz sk3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783334376; x=1783939176; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Go7lNGQE+yUmjPgVI2sZRhO3/S4lEXiftKalvVFj+z0=; b=lGDrFG2Dm/vpfFGgjGJGaDS05lDY2xcKtG2LhxaPyqj51VYr4RusaU/o2OpCasYCgy bhg+QVs4P0khrSS0bIL7EoeZz9jxW1A4viCEXHLVwkkaSUGer/xdY9KrYkADW8o4HEqU q6HByIocFPCoR8ExW35qTloy5AdFSfd7fZvqX7KSYyF9nNmH5KBe6zZCaa/LqRc/PCUW h0P1/LptyqZL+SQIhpyKVmmWMJubYRzl29oYrUKzDY/WpNmRSsRizbihAe4vuB8UmPp6 qJUHkez2UIKfCK+tVkZyQV9kZgvm4XDXsXV/qO24upwkdy4IX67ucK7cQrENuU+Afc3e JTlA== X-Forwarded-Encrypted: i=1; AHgh+RoWEOKJ2iNJQ92EFCftKlFXYiN74v/YZUPmhR2gvzV4YPW1SkNmJAZNqvVkuHwWCA6WItdM2uZWBCM=@vger.kernel.org X-Gm-Message-State: AOJu0YzcVqlCCtGhceZg7UeURuJdJziLnUm4jB2lC4giqtkv22u5d2hg XGUXXA4JcQ2JhrY8UHNDAcrUJl4iX7ZUbHtWidFfLxTiZGxpnW7fmhYjWDIbdOmSWtU= X-Gm-Gg: AfdE7ckFO5f7g7PIq7MA+DaqddPlZ00tlOo9LqsIDy/T0PXsHfQ/M7TwyznX7rTBT76 6qne5sfleypvcXg92FrEtwXNmHFDoDSGnCAyuXLB2avukWVOpJ0ZpT+Xw18K+rPxIVTggOvXm+/ Hy6ESbAbSskbVjLDavPqjNDwxbWFCqTVDNp1c7vEW3R5eqWr1DflXYyyEE/6K138V9nv9T7/rxX hvWYzMtQ562KuR1FUEKxM9PNbp52vrk3occFK9j1jeKFDUms4H4Owtl71vlec/ESiqT0k1eAxyV QQ9ykX8b0I0h+U2wfPTjp0N4prew3kMEp7/D/VG5hNGTCDJUaygroe/M9OywpKkkW/hWqanVnA3 hAkNRem8+2CwpWZP6qhSXC/7bsu5HcnQ2EuiyPjyM/ASuoiOZwlfkoVXKJqUn75TSOzwCQy15+5 CN69XR76yIs/Y4H4pD3sFM2RVgHx9EhcGqNowR1rjK6I5tfUsxV5+477cHVmJ+hlPJnWDpWgkLt fQO X-Received: by 2002:a05:6000:4698:b0:475:36a:8c97 with SMTP id ffacd0b85a97d-47aab76f017mr8079359f8f.45.1783334376207; Mon, 06 Jul 2026 03:39:36 -0700 (PDT) Received: from localhost (p200300f65f47db0426af56a07ec3b32d.dip0.t-ipconnect.de. [2003:f6:5f47:db04:26af:56a0:7ec3:b32d]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-47a9de1d8cdsm25702223f8f.1.2026.07.06.03.39.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2026 03:39:35 -0700 (PDT) Date: Mon, 6 Jul 2026 12:39:34 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: Chen Wang , linux-pwm@vger.kernel.org, Sven Peter , Janne Grunau , Neal Gompa , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Ray Jui , Scott Branden , Broadcom internal kernel review list , Florian Fainelli , Benson Leung , Guenter Roeck , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Paul Cercueil , Vladimir Zapolskiy , Piotr Wojtaszczyk , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Matthias Brugger , AngeloGioacchino Del Regno , Geert Uytterhoeven , Magnus Damm , Heiko Stuebner , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Paul Walmsley , Samuel Holland , Michael Walle , Inochi Amaoto , Orson Zhai , Baolin Wang , Chunyan Zhang , Fabrice Gasnier , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Jernej Skrabec , Hammer Hsieh , Nobuhiro Iwamatsu , Alexey Charkov , Sean Anderson , Michal Simek , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, chrome-platform@lists.linux.dev, imx@lists.linux.dev, linux-mips@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-riscv@lists.infradead.org, sophgo@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev Subject: Re: [PATCH v1 4/5] pwm: Unify coding style of of_device_id arrays Message-ID: References: <20de6cd60c2938aad2d21397b92742849418ab1b.1783263835.git.ukleinek@kernel.org> <973f3d6f-6ff4-4685-9c9f-b07987f74d98@linux.dev> Precedence: bulk X-Mailing-List: linux-pwm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="vyrf5kfcddz5uoeo" Content-Disposition: inline In-Reply-To: --vyrf5kfcddz5uoeo Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v1 4/5] pwm: Unify coding style of of_device_id arrays MIME-Version: 1.0 Hello, On Mon, Jul 06, 2026 at 10:28:16AM +0200, Philippe Mathieu-Daud=E9 wrote: > Hi Uwe, >=20 > On 6/7/26 09:19, Uwe Kleine-K=C3=B6nig (The Capable Hub) wrote: > > Hello Chen, > >=20 > > On Mon, Jul 06, 2026 at 08:33:47AM +0800, Chen Wang wrote: > > > On 7/5/2026 11:14 PM, Uwe Kleine-K=F6nig (The Capable Hub) wrote: > > > > - Use a single space in a of_device_id array terminator; A singl= e space > > > > after the opening { and before the closing } in non-empty > > > > initializers; > > > > - No comma after an array terminator; > > > > - Also no trailing comma after a named initializer iff the > > > iff -> if > >=20 > > This is actually intended. iff =3D "if and only if", see e.g. > > https://en.wikipedia.org/wiki/If_and_only_if . >=20 > I agree this scientific idiomatic expression is not well known > by non-native English speakers, and using the expanded form is > just simpler to review (thinking at non-native English speaker > reading your commit in the future). fine for me, I'll fixup to=20 - Also no trailing comma after a named initializer if (and only if) the closing } is on the same line; when applying. Best regards Uwe --vyrf5kfcddz5uoeo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmpLheQACgkQj4D7WH0S /k6DEQf+JKDZ+NcR412RMDPBxcWuk831SswOfJipQJVDxTsFWtpZIrZIbOu0ZlBp IEWpfB5nRfHwTSxF6Ceuf2jTc+wkwcRBKeH4MQsZFpGxBjGa4k7YEEfMSDU9S1vU 39G1FIVXnf0sDkUOUGf5zIomYewh4gdCoWRwDnCHsV4QnZKAaKCCEpX0U6QdW2OP diy3iqasYf6KZyXnUyj0HBQRGjBYY4jBvVutXt4KtCqAKW+AcCANOtubadJgydWD xXNkFLpscFQ9aVdyKZK19UP9yKdOwzkjR9pul+TqXDviO0c5UoAZEwMZYDbB1YPi AJloqZ9/3vBcnEjZo3eWYk8zkrQifQ== =vnC0 -----END PGP SIGNATURE----- --vyrf5kfcddz5uoeo--