Re: [PATCH 00/10] rust: refactor ARef and AlwaysRefCounted imports

Alice Ryhl
2025-11-25T12:39:50Z

On Sun, Nov 23, 2025 at 02:54:28PM +0530, Shankari Anand wrote:
> This series updates the import sites of `ARef` and
> `AlwaysRefCounted` in the Rust kernel code to use `sync::aref` instead
> of the previous `types` module.
>
> The refactor to `sync::aref` from `types::` was introduced in the commit:
> commit 07dad44aa9a9
> ("rust: kernel: move ARef and AlwaysRefCounted to sync::aref")
> link [1]
>
> The goal of this series is to complete the migration of these
> types to `sync`, as discussed with Miguel Ojeda [2].
> The last commit in this series removes the temporary re-exports
> from `types.rs` that were originally added to avoid breaking the
> build during the transition.
>
> [1]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=07dad44aa9a93b16af19e8609a10b241c352b440
> [2]: https://lore.kernel.org/lkml/CANiq72=hSTpAj7w8bvcwoJkivxD_FPKnx9jD6iNvhsENnnXBzg@mail.gmail.com/
>
> Shankari Anand (10):
> drivers: android: binder: Update ARef imports from sync::aref
> drivers: gpu: Update ARef imports from sync::aref
> rust: device: Update ARef and AlwaysRefCounted imports from sync::aref
> rust: drm: Update AlwaysRefCounted imports to use sync::aref
> rust: kernel: Update ARef and AlwaysRefCounted imports to use
> sync::aref
> rust: kernel: Update ARef and AlwaysRefCounted imports to use
> sync::aref
> rust: kernel: Update ARef imports to use sync::aref
> rust: kernel: Update AlwaysRefCounted imports to use sync::aref
> samples: rust: Update ARef imports to use sync::aref
> rust: kernel: remove temporary re-exports of ARef and AlwaysRefCounted
>
> drivers/android/binder/process.rs | 2 +-
> drivers/android/binder/thread.rs | 3 +--
> drivers/gpu/drm/tyr/driver.rs | 2 +-
> drivers/gpu/nova-core/gsp/sequencer.rs | 2 +-
> drivers/gpu/nova-core/vbios.rs | 2 +-
> rust/kernel/device.rs | 4 ++--
> rust/kernel/device/property.rs | 5 +++--
> rust/kernel/drm/gem/mod.rs | 2 +-
> rust/kernel/i2c.rs | 10 ++++------
> rust/kernel/pwm.rs | 3 ++-
> rust/kernel/scatterlist.rs | 3 ++-
> rust/kernel/types.rs | 2 --
> rust/kernel/usb.rs | 3 ++-
> samples/rust/rust_debugfs.rs | 2 +-
> 14 files changed, 22 insertions(+), 23 deletions(-)

I will pick up the DRM ones (patch 2 & 4) once the branch re-opens on
Dec 15th.

Alice