From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 425B830674D for ; Fri, 3 Jul 2026 16:38:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783096739; cv=none; b=tsB20+LquF2klbYPF951xp7lkwXpnYr+9DV9p2lgL/5Sgov7KiGvc/CMU6Jvos0dfUtyIkebbihV8UpHiiyZ1K+8YUtiQztZNGdDS3gDYy0Z1pqsEzYnd5ngbExxBwWRXQXAO9H/CdmHKRWLPqc7S1XC22M9rfvInqLd63YHolk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783096739; c=relaxed/simple; bh=nrFUeTISsssZEEKhYbH1QGl9yO+vtAmYijszoSwDM+A=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gaPRWZmvhTxwiJ0rPynGve8riY/WutyUNipK9j35RG+CgO8r2aaDdzaMj1/1a6LtXQn1Xnv8xia6BC4zoggeZollfVri3hF2vgStDcfYMUNyROLX2r2bFF/qTYDOfffJStudF9u0NU96Bg9BlSNsfitoxKXNU4+2nUz1gi+6biE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ggyc7vlG; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ggyc7vlG" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-490cf3000f0so6668475e9.1 for ; Fri, 03 Jul 2026 09:38:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783096737; x=1783701537; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=Dq50xUh9vnokWwn/2MgFrw6Bt3+wGtcUaeVmHV+z9uw=; b=Ggyc7vlGYIbSvGqthNUShze+DJZAsTFUaDbHlq36g348Cdb5niXyXxp+sUWKHgjZWW eAktUxb/FEeX2zjqolnvhIFfjnsSUM6IF+vE0DeFqf2e2MklvJ8S24i3B6z6IMQ+ZY57 9fHaoxM8umqHAHCrQ/dL+d7M3gZqPtFvsf6FWe0+LEzGlVDNpXdJsP7zlzGMXwogqbPm 6El1qBPJ5EOA+2SusUKKkFY+eO2ZuhsElxh+wP4lOQu4/Rqad1xhZUlR1/P9B07S/iw0 dos78O+MNfgcRplb6Pal03bPOllpnhKNakd0DUCNuEPonPvHYJHLGjmZ25GfyhNZJvfH 9QEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783096737; x=1783701537; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :sender:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Dq50xUh9vnokWwn/2MgFrw6Bt3+wGtcUaeVmHV+z9uw=; b=Sdy6bL0Uvtnem3JJYh5e95LScwK7RanmFtDeVd7FxQP6ElfR8p9s2kI2RujX79fDIo a4E8UuL16u2s7aiIiTs4/jaIvzMp269xnJol7E0CQR0eRPbzcnn9ISy05QePiPE9X0mJ +UIlq8pTc+fBgJX7IYtNJ637N9MYPe7pZIc5WWXO/W90z50InGdzl/NjsQhKeC3rUF9R ZeBdIxgiIyyDvsKSB1+Y4VVx9snmcJqpYVKOrjiXLj/MSIsaml0x4lhs0Q09dqhOC7xi Y/DfAx9VHfctb+UxoTn1YwVJiYEr3GUTmxwwtRc5Gma5QmYz2GdMw8UieMRodIBpGCag nu/Q== X-Forwarded-Encrypted: i=1; AFNElJ/qfKscJ1F575Gjk1XT6CSOnmzo2CFvr+B1Fd7Qq6zyAw7JjdQHUj0pKXLeHsd2iVY8V6Qpd7QT8hg=@vger.kernel.org X-Gm-Message-State: AOJu0Yy4xp4lzgRaDqf/8WtnCC+vuNjg88fq9fVZKUWdlX6jde+Zr6+r uUzAV0SI0j4wvz6yALb/jT3j9C0BPo520/cqO/JRwJ8u2combheovUN/ X-Gm-Gg: AfdE7cl7FP3Hq1ZgczHjjEnOZqEfNA9sRz0G0Oq7BhDMPzRGfU0YPVR+ZD9IFhu8Qul CePtMKRQSRcl3xkE7lOCbfHfu1IdTk1+ez9Iuy72T8ufT/cavIeuqfRSoGv9PdH9gredTuOTj/W SYKYnhjfuNa8hAj/5ZoLkXZirSvNSVYEC29+UHuQIBJASpRiJzs34z9xBDXl5e0LT0lsO07TQeo oTMJfSIwJ8GZsXQx0MkXXuSsJyM+bjA3lo6AwaMKJQRokVWao9xJb21444mrNuJByScNusQnaqZ s/VvSuCtnw2ZyDmWks42uR8ScJR1lrtZdOSUU35/rNg464Xa1Zqis3SsXqIGL3NkEknei5rN2Vq qPyaCYS0nbZCOpj+S30IQugJAmg+6X6qOqRfV5tXC+08b8axvhrdb20TeX2zdWSlmpDe5EE68dx mDVq4dWEyb+xnsWlD8ovwLk/dDvNOd4V53OztYx/DIGvs2ELMSyhS+18623ST+esqjdNl2jHBGI t8hriJl X-Received: by 2002:a05:600c:8105:b0:493:aaa2:f034 with SMTP id 5b1f17b1804b1-493d11f6cfamr400035e9.26.1783096736053; Fri, 03 Jul 2026 09:38:56 -0700 (PDT) Received: from [10.128.11.240] (195-23-151-163.net.novis.pt. [195.23.151.163]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493cce040b4sm82259395e9.10.2026.07.03.09.38.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Jul 2026 09:38:55 -0700 (PDT) Sender: Julian Braha Message-ID: Date: Fri, 3 Jul 2026 17:38:53 +0100 Precedence: bulk X-Mailing-List: linux-pwm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 2/3] pwm: rp1: Add RP1 PWM controller driver To: Andrea della Porta Cc: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , linux-pwm@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Naushir Patuck , Stanimir Varbanov , mbrugger@suse.com References: <0b6a7f41-b753-48dc-b46e-77aaf0e999f4@gmail.com> <6babbdea-fa93-4cd7-8198-5cd3accc34cc@gmail.com> Content-Language: en-US From: Julian Braha In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Andrea, On 7/3/26 15:56, Andrea della Porta wrote: > Honestly I don't have a strong opinion on that, but documenting is basically > the same than just selecting the option (well with the addition of the #), so > not really a difference. If there's no major concern about that I also wouuld > prefer to expicitly declare teh selecion of REGMAP_MMIO. My preference seems to be unpopular, so I've adjusted my reviews. - Julian Braha