From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f54.google.com (mail-ot1-f54.google.com [209.85.210.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B78F156230 for ; Mon, 14 Oct 2024 22:08:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728943731; cv=none; b=jII31sjQARGoZnd0qzAg9eF59rg+v6fZLmDoo6YmdvdFCwND2VUENz3GOcdZib9hHEGT5vsr9a94nUEuvOcPQ74dJ5hxL9ufzEoOukwMbI0d9A7FeKw9tAMff2nxQJae9wWgjaUtYnxJDK/g4SdaZG4CaG1qNh2wXozh49MEclg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728943731; c=relaxed/simple; bh=RwiWGV2rzLk4cT6vGo2hf7iXveFtHH9FPuvO1qveBSk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=a95UZmad7tIC9TBhLHM5/M6ocz4U7Huhix5IQbeG9/olU/8L8DH3/n6cQKm/EG+r/JZtz+E48m9+i3O34SnTqFOUvptfbVu2r+sndlvuALgZJTAZ09sEL5HzF+kT2daCJ2ZOgf/zWAASmQsqo3HdeLTpQ/DyWEOEFPwq6Zty/kE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=lT+tEeVN; arc=none smtp.client-ip=209.85.210.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="lT+tEeVN" Received: by mail-ot1-f54.google.com with SMTP id 46e09a7af769-715884fcf32so1830758a34.0 for ; Mon, 14 Oct 2024 15:08:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1728943728; x=1729548528; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CE71Pg+9qQgmK3mJbmPthhcZO1J5ofFDM3FllRmUogo=; b=lT+tEeVN0xGWgs+x4V9vNAiPWxKgu1AV3NjGgTIrMBGIXOf9+MhPnUKn1w9Q5QnPgU LQ/Z6dcbU1eYPKyXskY/O37o6ts3TRvVT9MXhf0TNXCvaPhA+jnUe/ta2i47mxVN+F/o wdSRHBLIYBx6837VAgQkbrwhCgl+J+0ASnprk/URj03MpbYCpRxwS+KNw+OH3sP4bi2N 9plioMKvVNGuPbEh9ovOa0OoNUFPMrrulp0lVt7kuUPg3/TrCBKXT49FGLTyOlnVxxNL p3+AH3FV+Otvi/Hqhn1bVRKSIID056yOlCNUasyj+lmK/aR/pCcjKRB/m2Kc9e805QDp +3Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728943728; x=1729548528; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CE71Pg+9qQgmK3mJbmPthhcZO1J5ofFDM3FllRmUogo=; b=ttZLLlmhIhY5ujg2bagVMXwPRaOvobjSPMqeIDF/VDhOElxe2VdQTUDHcdBt+GgEKX +o6ZqAqKwz5/qYboTUEf81Z8oSkeYoXHFN2uBBu/YqnQjmskiQjT5E6BwqCRlcidjhRC 8w5ftmAz0vA2346zJPnhMNtyV1wAG5NlymYRdDEt/x2lC08GsHU2eO8EY0Uo8ooTsslF 1K67LLrArFP4yNyO0jqD4cBI1lJZUjb4w30M7IXN8c8XDNysdM3sQbF9hJCLyv6081HD 8zmk6JZrivnIilKaPXaexLLvmWiUm4xVCSLh0QUejiJPdNBdvf5hN20p1yynF+FHG+YU HM0A== X-Forwarded-Encrypted: i=1; AJvYcCXjDdru/mFei67ToHQl9kAA3fg733NLhuPEY4eK1hE7+jZavDqSk/6ZE36RFxoblR4Q8esWL5ViBR4=@vger.kernel.org X-Gm-Message-State: AOJu0Yz7mFEYPg/6be1FLAs9wu40kZHvGMdlo+AukuB0RioidWLosdtG mcMzxnYke3lxvBgGNwd9tbRr6edgDAccRQIpmiCjyHO52ALkduFHmTx7VZnxhFc= X-Google-Smtp-Source: AGHT+IHJnl83Mw1D/U95VcdXHn7KiobS+KbDMYq68e+4vVzo3kcSL5k6sBEGoQjwDIdvMPPL4KFOQw== X-Received: by 2002:a05:6830:65c4:b0:703:6434:aba8 with SMTP id 46e09a7af769-717df1e1178mr7335220a34.0.1728943728669; Mon, 14 Oct 2024 15:08:48 -0700 (PDT) Received: from [192.168.0.142] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-717fb9f022asm13921a34.27.2024.10.14.15.08.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Oct 2024 15:08:48 -0700 (PDT) Message-ID: Date: Mon, 14 Oct 2024 17:08:47 -0500 Precedence: bulk X-Mailing-List: linux-pwm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 6/6] iio: adc: ad4851: add ad485x driver To: Andy Shevchenko , Antoniu Miclaus Cc: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Nuno Sa , Olivier Moysan , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Marcelo Schmitt , Ivan Mikhaylov , Marius Cristea , Dumitru Ceclan , =?UTF-8?Q?Jo=C3=A3o_Paulo_Gon=C3=A7alves?= , Alisa-Dariana Roman , Mike Looijmans , AngeloGioacchino Del Regno , Sergiu Cuciurean , Dragos Bogdan , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org References: <20241014094154.9439-1-antoniu.miclaus@analog.com> <20241014094154.9439-6-antoniu.miclaus@analog.com> Content-Language: en-US From: David Lechner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/14/24 8:14 AM, Andy Shevchenko wrote: > On Mon, Oct 14, 2024 at 12:40:40PM +0300, Antoniu Miclaus wrote: >> Add support for the AD485X a fully buffered, 8-channel simultaneous >> sampling, 16/20-bit, 1 MSPS data acquisition system (DAS) with >> differential, wide common-mode range inputs. > ... >> + return regmap_update_bits(st->regmap, AD4851_REG_PACKET, >> + AD4851_PACKET_FORMAT_MASK, (osr == 1) ? 0 : 1); > > I would do it with a conditional > > if (osr ...) > return regmap_update_bits(st->regmap, AD4851_REG_PACKET, > AD4851_PACKET_FORMAT_MASK, 0); > > return regmap_update_bits(st->regmap, AD4851_REG_PACKET, > AD4851_PACKET_FORMAT_MASK, 1); > If we do this, regmap_set_bits() and regmap_clear_bits() would be even better.