Linux PWM subsystem development
 help / color / mirror / Atom feed
From: David Lechner <dlechner@baylibre.com>
To: Antoniu Miclaus <antoniu.miclaus@analog.com>,
	jic23@kernel.org, robh@kernel.org, conor+dt@kernel.org,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org
Cc: Conor Dooley <conor.dooley@microchip.com>
Subject: Re: [PATCH v8 7/8] dt-bindings: iio: adc: add ad4851
Date: Fri, 13 Dec 2024 17:07:36 -0600	[thread overview]
Message-ID: <d2141b9c-33cb-48cf-97fa-49488edd63a0@baylibre.com> (raw)
In-Reply-To: <20241213164445.23195-7-antoniu.miclaus@analog.com>

On 12/13/24 10:44 AM, Antoniu Miclaus wrote:
> Add devicetree bindings for ad485x family.
> 
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> ---
> changes in v8:
>  - use "bipolar" property in adc channel definition.

...

> +patternProperties:
> +  "^channel(@[0-7])?$":
> +    $ref: adc.yaml
> +    type: object
> +    description: Represents the channels which are connected to the ADC.
> +
> +    properties:
> +      reg:
> +        description: The channel number in single-ended mode.
> +        minimum: 0
> +        maximum: 7

It looks like the diff-channels property from v7 has gone missing.

We can't know if an input is wired for single-ended or differential
without that.


> +
> +      bipolar: true
> +
> +    required:
> +      - reg
> +
> +    additionalProperties: false
> +

  reply	other threads:[~2024-12-13 23:07 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-13 16:44 [PATCH v8 1/8] iio: backend: add API for interface get Antoniu Miclaus
2024-12-13 16:44 ` [PATCH v8 2/8] iio: backend: add support for data size set Antoniu Miclaus
2024-12-13 23:09   ` David Lechner
2024-12-13 16:44 ` [PATCH v8 3/8] iio: backend: add API for oversampling Antoniu Miclaus
2024-12-13 23:10   ` David Lechner
2024-12-14 12:50     ` Jonathan Cameron
2024-12-13 16:44 ` [PATCH v8 4/8] iio: adc: adi-axi-adc: add interface type Antoniu Miclaus
2024-12-13 16:44 ` [PATCH v8 5/8] iio: adc: adi-axi-adc: set data format Antoniu Miclaus
2024-12-14 12:48   ` Jonathan Cameron
2024-12-13 16:44 ` [PATCH v8 6/8] iio: adc: adi-axi-adc: add oversampling Antoniu Miclaus
2024-12-13 16:44 ` [PATCH v8 7/8] dt-bindings: iio: adc: add ad4851 Antoniu Miclaus
2024-12-13 23:07   ` David Lechner [this message]
2024-12-13 16:44 ` [PATCH v8 8/8] iio: adc: ad4851: add ad485x driver Antoniu Miclaus
2024-12-13 23:43   ` David Lechner
2024-12-14 13:43   ` Jonathan Cameron
2024-12-13 23:07 ` [PATCH v8 1/8] iio: backend: add API for interface get David Lechner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d2141b9c-33cb-48cf-97fa-49488edd63a0@baylibre.com \
    --to=dlechner@baylibre.com \
    --cc=antoniu.miclaus@analog.com \
    --cc=conor+dt@kernel.org \
    --cc=conor.dooley@microchip.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox