From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claudiu Beznea Subject: Re: [PATCH v3 06/10] pwm: add PWM modes Date: Thu, 22 Feb 2018 19:42:29 +0200 Message-ID: References: <1519300881-8136-1-git-send-email-claudiu.beznea@microchip.com> <1519300881-8136-7-git-send-email-claudiu.beznea@microchip.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Andy Shevchenko Cc: Mark Rutland , milo.kim@ti.com, linux-fbdev@vger.kernel.org, Sean Young , devicetree , David Airlie , Michael Turquette , Joonas Lahtinen , kamil@wypas.org, dri-devel@lists.freedesktop.org, Linux Kernel Mailing List , Thierry Reding , Alexandre Belloni , Pavel Machek , Lee Jones , linux-clk@vger.kernel.org, Linux LED Subsystem , Daniel Thompson , linux-samsung-soc@vger.kernel.org, Alexander Shiyan , Jonathan Corbet , Linux Documentation List , Russell King - ARM Linux List-Id: linux-pwm@vger.kernel.org On 22.02.2018 19:28, Andy Shevchenko wrote: > On Thu, Feb 22, 2018 at 2:01 PM, Claudiu Beznea > wrote: >> Add PWM normal and complementary modes. > >> +- PWM_DTMODE_COMPLEMENTARY: PWM complementary working mode (for PWM >> +channels two outputs); if not specified, the default for PWM channel will >> +be used > > What DT stands for? It stands for Device Tree. It remained this way from the previous version. In the previous version I had modes described in an enum, to be used by PWM core, as follows: enum pwm_mode { PWM_MODE_NORMAL, PWM_MODE_COMPLEMENTARY, }; and, to avoid conflict b/w these defines and the one from include/dt-bindings/pwm/pwm.h I introduced this DT in the define names from dt-bindings. But now the DT might be removed since I've changed the way the PWM mode is identified in PWM core. I will remove the DT in the next version, if not requested otherwise. Thank you, Claudiu Benea