Linux PWM subsystem development
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Heiner Kallweit" <hkallweit1@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Kevin Hilman <khilman@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	linux-pwm@vger.kernel.org,
	"open list:ARM/Amlogic Meson..."
	<linux-amlogic@lists.infradead.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH RESEND v4] dt-bindings: pwm: Convert Amlogic Meson PWM binding
Date: Mon, 13 Mar 2023 08:49:12 +0100	[thread overview]
Message-ID: <ed2dc73d-d4cc-95fc-cd8b-52d37ebf149a@linaro.org> (raw)
In-Reply-To: <20230310181135.kiajexld3v655tph@pengutronix.de>

On 10/03/2023 19:11, Uwe Kleine-König wrote:
> On Mon, Feb 20, 2023 at 10:19:30PM +0100, Heiner Kallweit wrote:
>> Convert Amlogic Meson PWM binding to yaml.
>>
>> Reviewed-by: Rob Herring <robh@kernel.org>
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>> ---
>> Seems patch got lost over the question who takes it.
>> Please apply through the pwm tree.
> 
> Hmm, I found
> https://lore.kernel.org/linux-pwm/aaa73903-1837-d9c8-8c45-54b4473fd548@gmail.com
> which had no Reviewed-by tag where Krzysztof Kozlowski replied writing:
> "You got here a tag and my comment was about minor issue, so please keep
> that tag." I didn't find a thread where such a tag was given, though. I
> only found a review reply on v3 where Krzysztof requested a change (and
> didn't provide a tag).
> 
> The Reviewed-by tag for Rob probably originates from
> https://lore.kernel.org/linux-pwm/20230130212121.GA3468100-robh@kernel.org/.

Yes, Rob provided that tag. Since it is included here, looks fine.

> 
> And there is another variant where this patch was part of a series at
> https://lore.kernel.org/linux-pwm/5b83767e-c53d-316f-df10-45a39dbd9c88@gmail.com
> where it got an ack from me which wasn't included here.
> 
> To fix this:
> 
> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> 
> but please note that you can save some scarce maintainer time if you're
> more careful here.

Best regards,
Krzysztof


  reply	other threads:[~2023-03-13  7:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-20 21:19 [PATCH RESEND v4] dt-bindings: pwm: Convert Amlogic Meson PWM binding Heiner Kallweit
2023-03-10 18:11 ` Uwe Kleine-König
2023-03-13  7:49   ` Krzysztof Kozlowski [this message]
2023-04-06 13:45 ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ed2dc73d-d4cc-95fc-cd8b-52d37ebf149a@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=hkallweit1@gmail.com \
    --cc=jbrunet@baylibre.com \
    --cc=khilman@baylibre.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=neil.armstrong@linaro.org \
    --cc=robh+dt@kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox