From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Guenter Roeck" <linux@roeck-us.net>
Cc: Billy Tsai <billy_tsai@aspeedtech.com>,
jdelvare@suse.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, joel@jms.id.au,
andrew@aj.id.au, corbet@lwn.net, thierry.reding@gmail.com,
p.zabel@pengutronix.de, naresh.solanki@9elements.com,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, linux-pwm@vger.kernel.org,
BMC-SW@aspeedtech.com, patrick@stwcx.xyz
Subject: Re: [PATCH RESEND v10 0/3] Support pwm/tach driver for aspeed ast26xx
Date: Wed, 6 Dec 2023 18:56:35 +0100 [thread overview]
Message-ID: <ed9d28e0-f879-41f3-8679-7ed5e0eec7ce@linaro.org> (raw)
In-Reply-To: <20231206174823.ok6rrufhez33rte5@pengutronix.de>
On 06/12/2023 18:48, Uwe Kleine-König wrote:
> On Tue, Nov 07, 2023 at 11:02:43AM -0800, Guenter Roeck wrote:
>> On 11/7/23 02:50, Billy Tsai wrote:
>>> Unlike the old design that the register setting of the TACH should based
>>> on the configure of the PWM. In ast26xx, the dependency between pwm and
>>> tach controller is eliminated and becomes a separate hardware block. One
>>> is used to provide pwm output and another is used to monitor the frequency
>>> of the input. This driver implements them by exposing two kernel
>>> subsystems: PWM and HWMON. The PWM subsystem can be utilized alongside
>>> existing drivers for controlling elements such as fans (pwm-fan.c),
>>> beepers (pwm-beeper.c) and so on. Through the HWMON subsystem, the driver
>>> provides sysfs interfaces for fan.
>>>
>>> Changes since v9:
>>> Change the type of fan-driving-mode to string
>>> Fix some typos and formatting issues.
>>>
>>
>> What is the resend about ?
>
> And to the original v10 there is a reply by Krzysztof;
> see https://lore.kernel.org/linux-pwm/3d9e50db-19f0-43b3-8042-2f80a1e7b79e@linaro.org/ .
>
> I'll mark the original and this resend as "changes-requested" in our
> patchwork. Probably the most cooperative way to object is to send a v11
> and point out the changes compared to v10.
The resend might be fixing issues from v10, but who knows which and how
many. In any case it should be v11, not a resend.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-12-06 17:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-07 10:50 [PATCH RESEND v10 0/3] Support pwm/tach driver for aspeed ast26xx Billy Tsai
2023-11-07 10:50 ` [PATCH RESEND v10 1/3] dt-bindings: hwmon: fan: Add fan binding to schema Billy Tsai
2023-11-08 18:16 ` Rob Herring
2023-11-08 18:38 ` Guenter Roeck
2023-11-07 10:50 ` [PATCH RESEND v10 2/3] dt-bindings: hwmon: Support Aspeed g6 PWM TACH Control Billy Tsai
2023-11-08 18:21 ` Rob Herring
2023-11-14 3:11 ` Billy Tsai
2023-11-22 20:47 ` Rob Herring
2023-11-27 5:45 ` Billy Tsai
2024-01-13 1:53 ` Rob Herring
2023-11-07 10:50 ` [PATCH RESEND v10 3/3] hwmon: (aspeed-g6-pwm-tacho): Support for ASPEED g6 PWM/Fan tach Billy Tsai
2023-11-07 19:02 ` [PATCH RESEND v10 0/3] Support pwm/tach driver for aspeed ast26xx Guenter Roeck
2023-12-06 17:48 ` Uwe Kleine-König
2023-12-06 17:56 ` Krzysztof Kozlowski [this message]
2023-12-13 3:23 ` Billy Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed9d28e0-f879-41f3-8679-7ed5e0eec7ce@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=BMC-SW@aspeedtech.com \
--cc=andrew@aj.id.au \
--cc=billy_tsai@aspeedtech.com \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=naresh.solanki@9elements.com \
--cc=p.zabel@pengutronix.de \
--cc=patrick@stwcx.xyz \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).