linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Garth Snyder" <garth@grsweb.us>
To: 'Neil Brown' <neilb@suse.de>
Cc: linux-raid@vger.kernel.org
Subject: RE: Spare fails to transfer between RAID groups
Date: Tue, 12 May 2009 14:57:07 -0700	[thread overview]
Message-ID: <007c01c9d34c$9a618f70$cf24ae50$@us> (raw)
In-Reply-To: <18952.46349.611683.608352@notabene.brown>

On Sunday May 10, I (garth@grsweb.us) wrote:

> I'm having a problem getting a spare partition moved to the right RAID
group
> after a failure...All superblocks involved are version 1.2.

Neil Brown replied:

> This would be because no one has tried the spare-group feature with
> 1.x metadata yet...The following patch should make it work...This patch
> is against 2.6.9, though it should apply to any reasonably recent 2.x
mdadm.

Thanks for the response, Neil. The patch works great; now I get Fail,
MoveSpare, and Rebuild events in sequence with no errors. /proc/mdstat shows
that the appropriate spare was moved into the failed array and that the
array is being rebuilt onto it.

I patched the 2.6.7.1 tree, which was Jaunty's default for "apt-get source
mdadm" (and the same version included in the binary package). Manage.c and
Monitor.c already matched the "after" state of your patch, so the only code
that actually changed was the one-liners in super0.c and super1.c.

Thanks for the lightning-fast patch, and please let me know if there's
anything more I can do to help validate the fix.

Cheers,
Garth



  reply	other threads:[~2009-05-12 21:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-11  6:33 Spare fails to transfer between RAID groups Garth Snyder
2009-05-11 23:30 ` Neil Brown
2009-05-12 21:57   ` Garth Snyder [this message]
2009-05-13 11:07     ` Neil Brown
2009-05-13 21:49       ` Garth Snyder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='007c01c9d34c$9a618f70$cf24ae50$@us' \
    --to=garth@grsweb.us \
    --cc=linux-raid@vger.kernel.org \
    --cc=neilb@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).