Re: [PATCH 2/3] md: replace MD_DELETED with MD_CLOSING

[Yu Kuai <yukuai1@huaweicloud.com>]

Hi,

在 2025/05/09 18:20, Xiao Ni 写道:
> On Fri, May 9, 2025 at 6:08 PM Yu Kuai <yukuai1@huaweicloud.com> wrote:
>>
>> Hi,
>>
>> 在 2025/05/09 17:33, Xiao Ni 写道:
>>> The two places clear MD_CLOSING rather than setting MD_CLOSING.
>>> MD_CLOSING is set when we really want to stop the array (STOP_ARRAY
>>> cmd and clear>array_state_store). So the two places clear MD_CLOSING
>>> for other situations which look good to me.
>>
>> No, MD_CLOSING can be set first in the two cases, do something and then
>> be cleared, that's why I said temporarily.
> 
> So you mean mddev_get should pass in this case (between setting
> MD_CLOSING and clearing MD_CLOSING)? It doesn't allow get mddev now
> without this patch. This should be right.

I don't understand what you mean "It doesn't allow get mddev now without
this patch", for example, the ioctl STOP_ARRAY_RO will set MD_CLOSING
temporarily, but never set MD_DELETED, mddev_get() can always pass.

Thanks,
Kuai

> 
> Regardes
> Xiao
> 
>>
>> Thanks,
>> Kuai
>>
> 
> 
> .
>