linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Tkaczyk, Mariusz" <mariusz.tkaczyk@linux.intel.com>
To: linux-raid@vger.kernel.org
Subject: why RAID10 doesn't return BB during resync?
Date: Mon, 21 Dec 2020 12:52:19 +0100	[thread overview]
Message-ID: <0584a0dc-8bd9-c65d-7672-eea9cb900b9d@linux.intel.com> (raw)

Hi all,
I tested some scenarios with badblocks injected under same offset on each
member drive. For RAID1 and RAID5 IO errors and badblocks were reported
during resync, as expected. For RAID10 with default layout (n=2) I didn't
observe any IO error reported.

According to code, it looks like it was designed this way from the
beginning:

     /* find the first device with a block */
     for (i=0; i<conf->copies; i++)
         if (!r10_bio->devs[i].bio->bi_status)
             break;

     if (i == conf->copies)
         goto done;

There is no attempt to fix read error, it is ignored quietly.
The implementation differs from RAID1. For RAID1, there is
fix_sync_read_error() routine, and errors are well handled.

So my questions at this point are:
Is this a gap or it is intentionally omitted?
If it is a gap, is it worth to be added in the future?

Thanks,
Mariusz

                 reply	other threads:[~2020-12-21 11:54 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0584a0dc-8bd9-c65d-7672-eea9cb900b9d@linux.intel.com \
    --to=mariusz.tkaczyk@linux.intel.com \
    --cc=linux-raid@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).