From: Andrzej Jakowski <andrzej.jakowski@linux.intel.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: axboe@kernel.dk, song@kernel.org, linux-block@vger.kernel.org,
linux-raid@vger.kernel.org,
Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Subject: Re: [PATCH 1/2] block: introduce polling on bio level
Date: Fri, 31 Jan 2020 11:51:43 -0700 [thread overview]
Message-ID: <081badca-ab0f-f666-1e5e-71992f93a157@linux.intel.com> (raw)
In-Reply-To: <20200131063407.GB6267@infradead.org>
On 1/30/20 11:34 PM, Christoph Hellwig wrote:
> Can you explain this check? This looks weird to me I think we need
> a generalized check if a make_request based driver supports REQ_NOWAIT
> instead (and as a separate patch / patchset).
Original check used to reject polled IO for stackable block devices as
"not supported". To solve that situation I introduced additional check
to reject all non REQ_HIPRI requests. That check is not intended to
generalize, like you indicated, but to conservatively select which
requests to accept.
Perhaps there is better way to do that. Any suggestions?
next prev parent reply other threads:[~2020-01-31 18:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-26 4:41 [PATCH 0/2] Enable polling on stackable devices Andrzej Jakowski
2020-01-26 4:41 ` [PATCH 1/2] block: introduce polling on bio level Andrzej Jakowski
2020-01-30 4:01 ` Jens Axboe
2020-01-31 6:35 ` Christoph Hellwig
2020-02-01 4:41 ` Jens Axboe
2020-01-31 6:34 ` Christoph Hellwig
2020-01-31 18:51 ` Andrzej Jakowski [this message]
2020-02-01 8:20 ` Christoph Hellwig
2020-01-26 4:41 ` [PATCH 2/2] md: enable io polling Andrzej Jakowski
2020-01-31 6:36 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=081badca-ab0f-f666-1e5e-71992f93a157@linux.intel.com \
--to=andrzej.jakowski@linux.intel.com \
--cc=artur.paszkiewicz@intel.com \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).