Re: [PATCH 1/4] mdadm: Respect config file location in man

[Coly Li <colyli@suse.de>]

On 3/21/22 4:14 PM, Mariusz Tkaczyk wrote:
> On Sun, 20 Mar 2022 17:54:56 +0800
> Coly Li <colyli@suse.de> wrote:
>
>> On 3/18/22 4:26 PM, Lukasz Florczak wrote:
>>> Default config file location could differ depending on OS (e.g.
>>> Debian family). This patch takes default config file into
>>> consideration when creating mdadm.man file as well as
>>> mdadm.conf.man.
>>>
>>> Rename mdadm.conf.5 to mdadm.conf.5.in. Now mdadm.conf.5 is
>>> generated automatically.
>>>
>>> Signed-off-by: Lukasz Florczak <lukasz.florczak@linux.intel.com>
>>
>> I test and verify the change under openSUSE.
>>
>>
>> Acked-by: Coly Li <colyli@suse.de>
>>
>>
> Hi Coly,
> Could you please merge it to your master/for-jes branch then?

Sure, I will do it.

Just to confirm, for this situation, do you want me to add the patch 
directly to for-jes branch with my Acked-by: tag, or you will post 
another version with the Acked-by: tag?


> We have additional CI at Intel, based on our internal IMSM scope.
> I would like to switch it to your master/for-jes branch. Also I want to
> base future development on your tree.


Copied.


> Could you also elaborate more, what kind of testing are you doing?


Currently I only compile the patches, and create simple md raid1 
with/without container, and show them with mdadm -D and -E.

For the manual modification, it is checked by myself. I compile the man 
page, and check the CONFFILE and CONFFILE2 replacement in man page is 
correct on openSUSE. Then I run checkpatch.pl from Linux kernel with 
--codespell to check the patch style and basic spelling. And finally 
read the changed content of the man page.


> I think that is a good moment to give new life to mdadm test suite, if
> you are using it.


I am thinking of create another separate git repo, to store all the 
testing scripts, and run them on the mdadm-CI tree.

Thanks.


Coly Li