From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
Cc: Coly Li <colyli@suse.de>, Mike Snitzer <snitzer@redhat.com>,
Song Liu <song@kernel.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>,
Phillip Lougher <phillip@squashfs.org.uk>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"dm-devel@redhat.com" <dm-devel@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-bcache@vger.kernel.org" <linux-bcache@vger.kernel.org>,
"linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>,
"target-devel@vger.kernel.org" <target-devel@vger.kernel.org>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 2/5] squashfs: always use bio_kmalloc in squashfs_bio_read
Date: Wed, 6 Apr 2022 16:24:45 +0000 [thread overview]
Message-ID: <0a23a8fe-c298-3fa5-5d50-55d36d9bd14f@nvidia.com> (raw)
In-Reply-To: <20220406061228.410163-3-hch@lst.de>
On 4/5/22 23:12, Christoph Hellwig wrote:
> If a plain kmalloc that is not backed by a mempool is safe here for a
> large read (and the actual page allocations), it must also be for a
> small one, so simplify the code a bit.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Acked-by: Phillip Lougher <phillip@squashfs.org.uk>
> ---
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
next prev parent reply other threads:[~2022-04-06 17:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 6:12 cleanup bio_kmalloc v3 Christoph Hellwig
2022-04-06 6:12 ` [PATCH 1/5] btrfs: simplify ->flush_bio handling Christoph Hellwig
2022-04-06 16:23 ` Chaitanya Kulkarni
2022-04-06 6:12 ` [PATCH 2/5] squashfs: always use bio_kmalloc in squashfs_bio_read Christoph Hellwig
2022-04-06 16:24 ` Chaitanya Kulkarni [this message]
2022-04-06 6:12 ` [PATCH 3/5] target/pscsi: remove pscsi_get_bio Christoph Hellwig
2022-04-06 16:25 ` Chaitanya Kulkarni
2022-04-06 6:12 ` [PATCH 4/5] block: turn bio_kmalloc into a simple kmalloc wrapper Christoph Hellwig
2022-04-07 8:16 ` Coly Li
2022-04-13 17:04 ` Mike Snitzer
2022-04-06 6:12 ` [PATCH 5/5] pktcdvd: stop using bio_reset Christoph Hellwig
2022-04-15 4:57 ` cleanup bio_kmalloc v3 Christoph Hellwig
2022-04-18 1:32 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2022-03-08 6:15 cleanup bio_kmalloc v2 Christoph Hellwig
2022-03-08 6:15 ` [PATCH 2/5] squashfs: always use bio_kmalloc in squashfs_bio_read Christoph Hellwig
2022-03-01 8:45 cleanup bio_kmalloc Christoph Hellwig
2022-03-01 8:45 ` [PATCH 2/5] squashfs: always use bio_kmalloc in squashfs_bio_read Christoph Hellwig
2022-03-02 3:01 ` Phillip Lougher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a23a8fe-c298-3fa5-5d50-55d36d9bd14f@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=axboe@kernel.dk \
--cc=colyli@suse.de \
--cc=dm-devel@redhat.com \
--cc=dsterba@suse.com \
--cc=hch@lst.de \
--cc=josef@toxicpanda.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=phillip@squashfs.org.uk \
--cc=snitzer@redhat.com \
--cc=song@kernel.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).