2.2.17 -> 2.4.19-rc3: bub in file md.c, line 1311

2.2.17 -> 2.4.19-rc3: bub in file md.c, line 1311

[Hein Roehrig]

I am trying to (remotely) upgrade a kernel 2.2.17 with raid-2.2.17-A0
patch to 2.4.19-rc3 with the little attached patch to get autodetect
to work (sparc64 architecture.) Here is a partial manual transcript
from what appears on the console; the system still boots 2.2.17
without problem. I would be grateful for any advice on getting things
right...

Thanks,
Hein


md: linear personality registered as nr 1
md: raid 0 personality registered as nr 2
md: raid 1 personality registered as nr 3
md: raid 5 personality registered as nr 4
raid5: measuring checksumming speed
   VIS   : 113.600 MB/sec
raid5: using function: VIS (113.600 MB/sec)
md: md driver 0.90.0 MAX_MD_DEVS=256, MD_SB_DISKS=27
md: Autodetecting RAID arrays.
md:      [events:00000000]
md:      [events:00000000]
md:      [events:00000000]
md:      [events:00000000] 
md:      [events:00000000]   
md:      [events:00000000]
md:      [events:00000000] 
md:      [events:00000000]   
md:      [events:00000000]
md:      [events:00000000]
md:      [events:00000000]
md:      [events:00000000]
md: autorun
md: considering
md: adding sdf4
md: adding sde4
md: adding sdd4
md: adding sdc4
md: adding sda4
md: created md2
md: bind <sda4,1>
md: bind <sdc4,2>
md: bind <sdd4,3>
md: bind <sde4,4>
md: bind <sdf4,5>
md: running: <sdf4><sde4><sdd4><sdc4><sda4>
md: sdf4´s event counter: 00000000
md: device name has changed from [dev =3:08] to sdf4 since last impot!
md: bub in file md.c, line 1311

md:  **********************************
md:  * <COMPLETE RAID STATE PRINTOUT> *
md:  **********************************

md: <sdf4><sde4><sdd4><sdc4><sda4> array superblock
md:   SB: (V:0.90.0) ID: <2b62b4de.b2ac2edc.51dd7a78.2e9b708f> CT:38fa29a2

diff -ur clean/linux-2.4.19-rc3/fs/partitions/sun.c linux-2.4.19-rc3/fs/partitions/sun.c
--- clean/linux-2.4.19-rc3/fs/partitions/sun.c	Tue Oct  2 05:03:26 2001
+++ linux-2.4.19-rc3/fs/partitions/sun.c	Tue Jul 23 13:54:31 2002
@@ -19,6 +19,10 @@
 #include "check.h"
 #include "sun.h"
 
+#if CONFIG_BLK_DEV_MD
+extern void md_autodetect_dev(kdev_t dev);
+#endif
+
 int sun_partition(struct gendisk *hd, struct block_device *bdev, unsigned long first_sector, int first_part_minor)
 {
 	int i, csum;
@@ -27,7 +31,14 @@
 	kdev_t dev = to_kdev_t(bdev->bd_dev);
 	struct sun_disklabel {
 		unsigned char info[128];   /* Informative text string */
-		unsigned char spare[292];  /* Boot information etc. */
+		unsigned char spare0[14];
+		struct sun_disklabelinfo {
+			unsigned char spare1;
+			unsigned char id;
+			unsigned char spare2;
+			unsigned char flags;
+		} infos[8];
+		unsigned char spare1[246];  /* Boot information etc. */
 		unsigned short rspeed;     /* Disk rotational speed */
 		unsigned short pcylcount;  /* Physical cylinder count */
 		unsigned short sparecyl;   /* extra sects per cylinder */
@@ -77,8 +88,14 @@
 
 		st_sector = first_sector + be32_to_cpu(p->start_cylinder) * spc; 		num_sectors = be32_to_cpu(p->num_sectors);
-		if (num_sectors)
+		if (num_sectors) {
 			add_gd_partition(hd, first_part_minor, st_sector, num_sectors);
+#if CONFIG_BLK_DEV_MD
+			if (label->infos[i].id == LINUX_RAID_PARTITION) {
+			    md_autodetect_dev(MKDEV(hd->major, first_part_minor));
+			}
+#endif
+                }
 		first_part_minor++;
 	}
 	printk("\n");


-
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: 2.2.17 -> 2.4.19-rc3: bub in file md.c, line 1311

[Neil Brown]

On  July 23, hpr@eml.cc wrote:
> I am trying to (remotely) upgrade a kernel 2.2.17 with raid-2.2.17-A0
> patch to 2.4.19-rc3 with the little attached patch to get autodetect
> to work (sparc64 architecture.) Here is a partial manual transcript
> from what appears on the console; the system still boots 2.2.17
> without problem. I would be grateful for any advice on getting things
> right...

The 2.2 patches got the superblock layout wrong for sparc64, so raid
array made on those systems are not directly compatable with 2.4.

You can convert the arrays using mdadm 1.0.1 which can be found at
  http://www.cse.unsw.edu.au/~neilb/source/mdadm/

For each component device:
 mdadm -E /dev/devicename
should show rubbish in the device table at the bottom as the
superblock layout is wrong
 mdadm -E --sparc2.2 /dev/devicename
should show correct information in the device table.
If it does then:
 mdadm -E --sparc2.2update /dev/devicename
should correct the superblock for 2.4. After this
 mdadm -E /dev/devicename
will show correct devices and
 mdadm -A /dev/mdX /dev/sd.....

should assemble the devices successfully.

NeilBrown

Re: 2.2.17 -> 2.4.19-rc3: bub in file md.c, line 1311

[Hein Roehrig]

On Wed, 2002-07-24 at 09:45, Neil Brown wrote:
> The 2.2 patches got the superblock layout wrong for sparc64, so raid
> array made on those systems are not directly compatable with 2.4.

Ah, thanks for the information, I hadn't found that on Google or the
mailing list archive.

I gather that fixing the superblock for 2.4 will make it unusuable for
2.2? So I'll have to be very careful... 

Thanks,
Hein