SW-RAID1 and 2.5.34

SW-RAID1 and 2.5.34

[Dirk Meul]

Hello.

I'm not able to boot plain 2.5.34 with RAID1 enabled. My root partition
is RAID1 and with 2.4.19 everything is ok. But bug on md.c:3153 in
md_queue_proc. What can i do to fix it?

Regards,

PS.: Please send me a CC, thanks. 
-- 
Dirk Meul <dirk.meul@epost.de>

Re: SW-RAID1 and 2.5.34

[Neil Brown]

On  September 12, dirk.meul@epost.de wrote:
> Hello.
> 
> I'm not able to boot plain 2.5.34 with RAID1 enabled. My root partition
> is RAID1 and with 2.4.19 everything is ok. But bug on md.c:3153 in
> md_queue_proc. What can i do to fix it?

The patch just went it Linus' BK tree.
It is below.
I don't promise that this fixes everything, just that if fixes the
"bug at md.c:3153".

NeilBrown


Remove BUG in md.c that change in 2.5.33 triggers.

Since 2.5.33, the blk_dev[].queue is called without
the device open, so md_queue_proc can no-longer assume
that the device is open.



 ----------- Diffstat output ------------
 ./drivers/md/md.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

--- ./drivers/md/md.c	2002/09/11 00:27:10	1.1
+++ ./drivers/md/md.c	2002/09/11 00:37:33	1.2
@@ -3149,11 +3149,11 @@ request_queue_t * md_queue_proc(kdev_t d
 {
 	mddev_t *mddev = mddev_find(minor(dev));
 	request_queue_t *q = BLK_DEFAULT_QUEUE(MAJOR_NR);
-	if (!mddev || atomic_read(&mddev->active)<2)
-		BUG();
-	if (mddev->pers)
-		q = &mddev->queue;
-	mddev_put(mddev); /* the caller must hold a reference... */
+	if (mddev) {
+		if (mddev->pers)
+			q = &mddev->queue;
+		mddev_put(mddev);
+	}
 	return q;
 }
 

Re: SW-RAID1 and 2.5.34

[Dirk Meul]

Thank you!

Am Fre, 2002-09-13 um 02.44 schrieb Neil Brown:
> > I'm not able to boot plain 2.5.34 with RAID1 enabled. My root partition
> > is RAID1 and with 2.4.19 everything is ok. But bug on md.c:3153 in
> > md_queue_proc. What can i do to fix it?
> 
> The patch just went it Linus' BK tree.
> It is below.
> I don't promise that this fixes everything, just that if fixes the
> "bug at md.c:3153".

With the patch applied the kernel didn't oops, but 2.5.34 tries to use
hde2. The RAID1 partitions are hde1/hdg1! hde2 is a swap partition so
following message is correct:
invalid raid superblock magic on hde2.

There is a [events: a8bc0fb6] message.

How can i fix this? Or do i have to make a new RAID1 device?

Regards,
-- 
Dirk Meul <dirk.meul@epost.de>