From: NeilBrown <neilb@suse.de>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-raid@vger.kernel.org
Subject: [PATCH md 001 of 3] Really get sb_size setting right in all cases.
Date: Tue, 6 Sep 2005 13:53:02 +1000 [thread overview]
Message-ID: <1050906035302.19309@suse.de> (raw)
In-Reply-To: 20050906134923.19249.patches@notabene
There was another case where sb_size wasn't being set, so
instead do the sensible thing and set if when filling in the
content of a superblock. That ensures that whenever we
write a superblock, the sb_size MUST be set.
Signed-off-by: Neil Brown <neilb@suse.de>
### Diffstat output
./drivers/md/md.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff ./drivers/md/md.c~current~ ./drivers/md/md.c
--- ./drivers/md/md.c~current~ 2005-09-02 19:29:31.000000000 +1000
+++ ./drivers/md/md.c 2005-09-05 14:47:45.000000000 +1000
@@ -712,6 +712,8 @@ static void super_90_sync(mddev_t *mddev
int i;
int active=0, working=0,failed=0,spare=0,nr_disks=0;
+ rdev->sb_size = MD_SB_BYTES;
+
sb = (mdp_super_t*)page_address(rdev->sb_page);
memset(sb, 0, sizeof(*sb));
@@ -2303,8 +2305,6 @@ static int add_new_disk(mddev_t * mddev,
else
rdev->in_sync = 0;
- rdev->sb_size = MD_SB_BYTES;
-
if (info->state & (1<<MD_DISK_WRITEMOSTLY))
set_bit(WriteMostly, &rdev->flags);
next prev parent reply other threads:[~2005-09-06 3:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-06 3:52 [PATCH md 000 of 3] Introduction NeilBrown
2005-09-06 3:53 ` NeilBrown [this message]
2005-09-06 3:53 ` [PATCH md 002 of 3] Fix raid10 assembly when too many devices are missing NeilBrown
2005-09-06 3:53 ` [PATCH md 003 of 3] Fix BUG when raid10 rebuilds without enough drives NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1050906035302.19309@suse.de \
--to=neilb@suse.de \
--cc=akpm@osdl.org \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).