* [PATCH md 000 of 2] Introduction
@ 2005-12-05 3:17 NeilBrown
2005-12-05 3:17 ` [PATCH md 001 of 2] Change case of raid level reported in sys/mdX/md/level NeilBrown
2005-12-05 3:17 ` [PATCH md 002 of 2] Remove inappropriate limits in md/bitmap configuration NeilBrown
0 siblings, 2 replies; 3+ messages in thread
From: NeilBrown @ 2005-12-05 3:17 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-raid
Following are two patches for md in 2.6.15-rc what should get into
2.6.15-final if possible.
The first refines a newly created interface (/sys/block/mdX/md/level).
I've decided that 'raid5' is better than 'RAID-5' after all.
The second removes some limits that shouldn't really be imposed in the kernel.
Thanks,
NeilBrown
[PATCH md 001 of 2] Change case of raid level reported in sys/mdX/md/level
[PATCH md 002 of 2] Remove inappropriate limits in md/bitmap configuration.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH md 001 of 2] Change case of raid level reported in sys/mdX/md/level
2005-12-05 3:17 [PATCH md 000 of 2] Introduction NeilBrown
@ 2005-12-05 3:17 ` NeilBrown
2005-12-05 3:17 ` [PATCH md 002 of 2] Remove inappropriate limits in md/bitmap configuration NeilBrown
1 sibling, 0 replies; 3+ messages in thread
From: NeilBrown @ 2005-12-05 3:17 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-raid
I had thought that keeping the reported raid level clearly
different from the module name was a good idea, but I've changed
my mind.
'raid5' is better and probably less confusing than 'RAID-5'.
Signed-off-by: Neil Brown <neilb@suse.de>
### Diffstat output
./drivers/md/md.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff ./drivers/md/md.c~current~ ./drivers/md/md.c
--- ./drivers/md/md.c~current~ 2005-12-05 10:22:30.000000000 +1100
+++ ./drivers/md/md.c 2005-12-05 10:23:51.000000000 +1100
@@ -1730,7 +1730,7 @@ level_show(mddev_t *mddev, char *page)
if (p == NULL && mddev->raid_disks == 0)
return 0;
if (mddev->level >= 0)
- return sprintf(page, "RAID-%d\n", mddev->level);
+ return sprintf(page, "raid%d\n", mddev->level);
else
return sprintf(page, "%s\n", p->name);
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH md 002 of 2] Remove inappropriate limits in md/bitmap configuration.
2005-12-05 3:17 [PATCH md 000 of 2] Introduction NeilBrown
2005-12-05 3:17 ` [PATCH md 001 of 2] Change case of raid level reported in sys/mdX/md/level NeilBrown
@ 2005-12-05 3:17 ` NeilBrown
1 sibling, 0 replies; 3+ messages in thread
From: NeilBrown @ 2005-12-05 3:17 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-raid
The kernel should not be imposing these policy limits:
The time between bitmap updates should certainly be allowed
to be more than 15 seconds, and if someone wants a bitmap chunk size
in excess of 4MB, the kernel isn't the place to stop them.
Signed-off-by: Neil Brown <neilb@suse.de>
### Diffstat output
./drivers/md/bitmap.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff ./drivers/md/bitmap.c~current~ ./drivers/md/bitmap.c
--- ./drivers/md/bitmap.c~current~ 2005-12-05 10:22:31.000000000 +1100
+++ ./drivers/md/bitmap.c 2005-12-05 10:28:09.000000000 +1100
@@ -485,12 +485,12 @@ static int bitmap_read_sb(struct bitmap
else if (le32_to_cpu(sb->version) < BITMAP_MAJOR_LO ||
le32_to_cpu(sb->version) > BITMAP_MAJOR_HI)
reason = "unrecognized superblock version";
- else if (chunksize < 512 || chunksize > (1024 * 1024 * 4))
- reason = "bitmap chunksize out of range (512B - 4MB)";
+ else if (chunksize < PAGE_SIZE)
+ reason = "bitmap chunksize too small";
else if ((1 << ffz(~chunksize)) != chunksize)
reason = "bitmap chunksize not a power of 2";
- else if (daemon_sleep < 1 || daemon_sleep > 15)
- reason = "daemon sleep period out of range (1-15s)";
+ else if (daemon_sleep < 1 || daemon_sleep > MAX_SCHEDULE_TIMEOUT / HZ)
+ reason = "daemon sleep period out of range";
else if (write_behind > COUNTER_MAX)
reason = "write-behind limit out of range (0 - 16383)";
if (reason) {
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-12-05 3:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-12-05 3:17 [PATCH md 000 of 2] Introduction NeilBrown
2005-12-05 3:17 ` [PATCH md 001 of 2] Change case of raid level reported in sys/mdX/md/level NeilBrown
2005-12-05 3:17 ` [PATCH md 002 of 2] Remove inappropriate limits in md/bitmap configuration NeilBrown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).