From: NeilBrown <neilb@suse.de>
To: Andrew Morton <akpm@osdl.org>, stable@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org
Subject: [PATCH] Fix bug: BIO_RW_BARRIER requests to md/raid1 hang.
Date: Thu, 23 Mar 2006 14:41:16 +1100 [thread overview]
Message-ID: <1060323034116.13086@suse.de> (raw)
In-Reply-To: 20060323143936.13067.patches@notabene
The following fixes a rather embarassing bug in 2.6.16, and so should
go into 2.6.16.1, and 2.6.16-rc1.
Thanks,
NeilBrown
### Comments for Changeset
Both R1BIO_Barrier and R1BIO_Returned are 4 !!!!
This means that barrier requests don't get returned (i.e. b_endio
called) because it looks like they already have been.
Signed-off-by: Neil Brown <neilb@suse.de>
### Diffstat output
./include/linux/raid/raid1.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff ./include/linux/raid/raid1.h~current~ ./include/linux/raid/raid1.h
--- ./include/linux/raid/raid1.h~current~ 2006-03-23 13:46:27.000000000 +1100
+++ ./include/linux/raid/raid1.h 2006-03-23 14:36:53.000000000 +1100
@@ -130,6 +130,6 @@ struct r1bio_s {
* with failure when last write completes (and all failed).
* Record that bi_end_io was called with this flag...
*/
-#define R1BIO_Returned 4
+#define R1BIO_Returned 6
#endif
parent reply other threads:[~2006-03-23 3:41 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20060323143936.13067.patches@notabene>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1060323034116.13086@suse.de \
--to=neilb@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).