From: NeilBrown <neilb@suse.de>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 002 of 3] md: Fix inverted test for 'repair' directive.
Date: Tue, 16 May 2006 11:13:07 +1000 [thread overview]
Message-ID: <1060516011307.2723@suse.de> (raw)
In-Reply-To: 20060516111036.2649.patches@notabene
We should be able to write 'repair' to /sys/block/mdX/md/sync_action,
however due to and inverted test, that always given EINVAL.
Signed-off-by: Neil Brown <neilb@suse.de>
### Diffstat output
./drivers/md/md.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff ./drivers/md/md.c~current~ ./drivers/md/md.c
--- ./drivers/md/md.c~current~ 2006-05-16 11:09:25.000000000 +1000
+++ ./drivers/md/md.c 2006-05-16 11:09:41.000000000 +1000
@@ -2318,7 +2318,7 @@ action_store(mddev_t *mddev, const char
} else {
if (cmd_match(page, "check"))
set_bit(MD_RECOVERY_CHECK, &mddev->recovery);
- else if (cmd_match(page, "repair"))
+ else if (!cmd_match(page, "repair"))
return -EINVAL;
set_bit(MD_RECOVERY_REQUESTED, &mddev->recovery);
set_bit(MD_RECOVERY_SYNC, &mddev->recovery);
next prev parent reply other threads:[~2006-05-16 1:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-16 1:12 [PATCH 000 of 3] md: Introduction - 3 bugfixs for -mm NeilBrown
2006-05-16 1:13 ` [PATCH 001 of 3] md: Change md/bitmap file handling to use bmap to file blocks-fix NeilBrown
2006-05-16 1:54 ` Andrew Morton
2006-05-16 2:16 ` Neil Brown
2006-05-16 1:13 ` NeilBrown [this message]
2006-05-16 1:13 ` [PATCH 003 of 3] md: Calculate correct array size for raid10 in new offset mode NeilBrown
2006-05-17 12:04 ` [PATCH 000 of 3] md: Introduction - 3 bugfixs for -mm Reuben Farrelly
2006-05-17 23:28 ` Neil Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1060516011307.2723@suse.de \
--to=neilb@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).