From: NeilBrown <neilb@suse.de>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 006 of 6] md: Add error reporting to superblock write failure
Date: Fri, 29 Sep 2006 12:53:32 +1000 [thread overview]
Message-ID: <1060929025332.15323@suse.de> (raw)
In-Reply-To: 20060929125047.14064.patches@notabene
Signed-off-by: Neil Brown <neilb@suse.de>
### Diffstat output
./drivers/md/md.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff .prev/drivers/md/md.c ./drivers/md/md.c
--- .prev/drivers/md/md.c 2006-09-29 11:49:00.000000000 +1000
+++ ./drivers/md/md.c 2006-09-29 11:51:39.000000000 +1000
@@ -389,8 +389,12 @@ static int super_written(struct bio *bio
if (bio->bi_size)
return 1;
- if (error || !test_bit(BIO_UPTODATE, &bio->bi_flags))
+ if (error || !test_bit(BIO_UPTODATE, &bio->bi_flags)) {
+ printk("md: super_written gets error=%d, uptodate=%d\n",
+ error, test_bit(BIO_UPTODATE, &bio->bi_flags));
+ WARN_ON(test_bit(BIO_UPTODATE, &bio->bi_flags));
md_error(mddev, rdev);
+ }
if (atomic_dec_and_test(&mddev->pending_writes))
wake_up(&mddev->sb_wait);
prev parent reply other threads:[~2006-09-29 2:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-29 2:52 [PATCH 000 of 6] md: Introduction NeilBrown
2006-09-29 2:52 ` [PATCH 001 of 6] md: Fix duplicity of levels in md.txt NeilBrown
2006-09-29 2:52 ` [PATCH 002 of 6] md: Remove MAX_MD_DEVS which is an arbitrary limit NeilBrown
2006-09-29 2:53 ` [PATCH 003 of 6] md: Remove 'experimental' classification from raid5 reshape NeilBrown
2006-09-29 4:24 ` Jeff Breidenbach
2006-10-02 8:07 ` David Greaves
2006-09-29 2:53 ` [PATCH 004 of 6] md: Use ffz instead of find_first_set to convert multiplier to shift NeilBrown
2006-09-29 2:53 ` [PATCH 005 of 6] md: Allow SET_BITMAP_FILE to work on 64bit kernel with 32bit userspace NeilBrown
2006-09-29 2:53 ` NeilBrown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1060929025332.15323@suse.de \
--to=neilb@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).