From: Xiao Ni <xni@redhat.com>
To: linux-raid@vger.kernel.org
Subject: [PATCH] Recovery speed is wrong
Date: Thu, 7 Aug 2014 09:37:41 -0400 (EDT) [thread overview]
Message-ID: <1135772294.19428712.1407418661354.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <1888683818.19423710.1407418230213.JavaMail.zimbra@redhat.com>
Hi all
When we calculate the speed of recovery, the numerator that contains the recovery done sectors.
It's need to subtract the sectors which don't finish recovery.
Signed-off-by: Xiao Ni <xni@redhat.com>
diff -urN linux-stable/drivers/md/md.c fix/md.c
--- linux-stable/drivers/md/md.c 2014-07-30 14:36:37.327535805 +0800
+++ fix/md.c 2014-08-07 16:07:12.559503942 +0800
@@ -7376,7 +7376,7 @@
struct mddev *mddev2;
unsigned int currspeed = 0,
window;
- sector_t max_sectors,j, io_sectors;
+ sector_t max_sectors,j, io_sectors, recovery_done;
unsigned long mark[SYNC_MARKS];
unsigned long update_time;
sector_t mark_cnt[SYNC_MARKS];
@@ -7652,7 +7652,8 @@
*/
cond_resched();
- currspeed = ((unsigned long)(io_sectors-mddev->resync_mark_cnt))/2
+ recovery_done = io_sectors - atomic_read(&mddev->recovery_active);
+ currspeed = ((unsigned long)recovery_done - mddev->resync_mark_cnt)/2
/((jiffies-mddev->resync_mark)/HZ +1) +1;
if (currspeed > speed_min(mddev)) {
next parent reply other threads:[~2014-08-07 13:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1888683818.19423710.1407418230213.JavaMail.zimbra@redhat.com>
2014-08-07 13:37 ` Xiao Ni [this message]
2014-08-08 2:21 ` [PATCH] Recovery speed is wrong NeilBrown
2014-08-08 7:36 ` Xiao Ni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1135772294.19428712.1407418661354.JavaMail.zimbra@redhat.com \
--to=xni@redhat.com \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).