linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Doug Ledford <dledford@redhat.com>
To: Neil Brown <neilb@suse.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
	Peter Rabbitson <rabbit+list@rabbit.us>,
	linux-raid@vger.kernel.org
Subject: Re: Proper partition type for components with V1.x superblocks?
Date: Mon, 07 Jul 2008 10:02:40 -0400	[thread overview]
Message-ID: <1215439360.14196.17.camel@firewall.xsintricity.com> (raw)
In-Reply-To: <18545.35548.800516.532854@notabene.brown>

[-- Attachment #1: Type: text/plain, Size: 2063 bytes --]

On Mon, 2008-07-07 at 13:17 +1000, Neil Brown wrote:
> On Thursday July 3, dledford@redhat.com wrote:
> > Actually, if you are going to use version 1 superblocks anyway, then
> > just list the partitions as normal linux partitions.  The whole
> > linux-raid-autodetect partition type was originally only for auto detect
> > at bootup.  If you weren't using that feature, then standard linux type
> > was good enough.  And if you use version 1.1 or 1.2 superblocks, then
> > you really don't have anything to worry about since the location of the
> > superblock and the data start offset means that the partition won't get
> > accidentally recognized as a non-raid partition.
> 
> But if you use 1.0, then some well-meaning install program might mount
> one drive from a raid1 as a filesystem, write to it, and get your RAID
> all out of sync.

The same is true of version 0.90.0 superblocks.  It was probably a bad
decision to make raid1 arrays mountable as normal filesystems in
hindsight, but it did ease a lot of things at the time (like booting
from a raid1 device using lilo, the only boot loader back in the day).
In any case, given the number of existing 0.90.0 and 1.0 superblock
systems out there, any install code that doesn't look for them is just
flat deficient.  So I can see your point from the stand point of wanting
to correct a past mistake, but the flip side of the coin is that even if
you do such a thing, any installer will still be buggy and broken for
many years to come if it doesn't check for raid superblocks before
treating a filesystem like a normal filesystem.

> The whole point of this exercise was to find a way to make sure code
> that took the partition type to mean something didn't make the wrong
> decision.  0xDA seems the best answer for that.
> 
> NeilBrown
>  
-- 
Doug Ledford <dledford@redhat.com>
              GPG KeyID: CFBFF194
              http://people.redhat.com/dledford

Infiniband specific RPMs available at
              http://people.redhat.com/dledford/Infiniband


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

  reply	other threads:[~2008-07-07 14:02 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-11  9:26 Proper partition type for components with V1.x superblocks? Peter Rabbitson
2008-06-11 11:23 ` Andre Noll
2008-06-11 12:12   ` Peter Rabbitson
2008-06-11 21:06     ` Andre Noll
2008-06-11 11:24 ` David Greaves
2008-06-11 11:35   ` Peter Rabbitson
2008-06-11 23:52 ` Neil Brown
2008-07-02 22:02   ` H. Peter Anvin
2008-07-03  5:17     ` Doug Ledford
2008-07-07  3:17       ` Neil Brown
2008-07-07 14:02         ` Doug Ledford [this message]
2008-07-07 17:33           ` H. Peter Anvin
2008-07-07 17:32         ` H. Peter Anvin
2008-07-07 23:10           ` David Greaves
2008-07-07 23:47             ` H. Peter Anvin
2008-07-07 17:38         ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1215439360.14196.17.camel@firewall.xsintricity.com \
    --to=dledford@redhat.com \
    --cc=hpa@zytor.com \
    --cc=linux-raid@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=rabbit+list@rabbit.us \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).