From: raz ben yehuda <raziebe@gmail.com>
To: Andre Noll <maan@systemlinux.org>
Cc: linux-raid@vger.kernel.org
Subject: Re: [PATCH 0/6] md: Remove the hash tables from raid0.
Date: Thu, 14 May 2009 15:42:46 +0300 [thread overview]
Message-ID: <1242304966.3500.0.camel@raz> (raw)
In-Reply-To: <1242293462-4181-1-git-send-email-maan@systemlinux.org>
where are the patches ?
On Thu, 2009-05-14 at 11:30 +0200, Andre Noll wrote:
> As mentioned by Neil, the raid0 hash table code does probably not
> add any value. Moreover, it contains some rather strange sector_t
> manipulations which are needed to setup and maintain the table.
>
> This patch series against Neil's for-next tree as of yesterday removes
> the hash table from the raid0 code.
>
> Patch #1 replaces the hash table lookup by a simple function that
> loops over all strip zones to find the zone that holds a given sector.
> This change allows to get rid of the hash table itself (patch #2)
> and of related fields of struct raid0_private_data (patch #3).
>
> Patch #4 makes raid0 return a proper error code rather than -ENOMEM
> in case the array could not be started for reasons other than memory
> shortage.
>
> The remaining two patches are simple cleanups that further simplify
> the raid0 code a bit.
>
> The patched kernel has been tested with a smallish raid0 array
> consisting of five devices of varying sizes (created and filled with
> contents by an unpatched kernel) and seems to work just fine. It
> passes the raid0 tests of the mdadm test suite.
>
> Please consider for inclusion.
>
> drivers/md/raid0.c | 150 ++++++++++++++--------------------------------------
> drivers/md/raid0.h | 4 --
> 2 files changed, 39 insertions(+), 115 deletions(-)
>
> Thanks
> Andre
next prev parent reply other threads:[~2009-05-14 12:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-14 9:30 [PATCH 0/6] md: Remove the hash tables from raid0 Andre Noll
2009-05-14 9:30 ` [PATCH 1/6] md: raid0: Replace hash table lookup by looping over all strip_zones Andre Noll
2009-05-14 9:30 ` [PATCH 2/6] md: raid0: Remove hash table Andre Noll
2009-05-14 9:30 ` [PATCH 3/6] md: raid0: Remove hash spacing and sector shift Andre Noll
2009-05-14 9:31 ` [PATCH 4/6] md: raid0: Make raid0_run() return a proper error code Andre Noll
2009-05-14 9:31 ` [PATCH 5/6] md: raid0: Kfree() strip_zone and devlist in create_strip_zones() Andre Noll
2009-05-14 9:31 ` [PATCH 6/6] md: raid0: Simplify raid0_run() Andre Noll
2009-05-14 12:42 ` raz ben yehuda [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-05-14 10:43 [PATCH 0/6] md: Remove the hash tables from raid0 Andre Noll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1242304966.3500.0.camel@raz \
--to=raziebe@gmail.com \
--cc=linux-raid@vger.kernel.org \
--cc=maan@systemlinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).