From: raz ben yehuda <raziebe@gmail.com>
To: linux raid <linux-raid@vger.kernel.org>, Neil Brown <neilb@suse.de>
Cc: yaron <yaronp@bitband.com>, ofer <ofer@bitband.com>
Subject: Subject: [PATCH 008/009]: raid5: chunk size check in run
Date: Tue, 19 May 2009 19:07:43 +0300 [thread overview]
Message-ID: <1242749263.3293.67.camel@raz> (raw)
have raid5 check chunk size in run method instead of in md
raid5.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
Signed-Off-by:raziebe@gmail.com
diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
index e4608d6..0c688ee 100644
--- a/drivers/md/raid5.c
+++ b/drivers/md/raid5.c
@@ -4452,7 +4452,15 @@ static int run(mddev_t *mddev)
raid5_conf_t *conf;
int working_disks = 0;
mdk_rdev_t *rdev;
-
+ /*
+ * chunk-size has to be a power of 2
+ */
+ if ((1 << ffz(~mddev->chunk_size)) != mddev->chunk_size) {
+ printk(KERN_ERR "%s chunk_size of %d not valid\n",
+ mdname(mddev),
+ mddev->chunk_size);
+ return -EINVAL;
+ }
if (mddev->reshape_position != MaxSector) {
/* Check that we can continue the reshape.
* Currently only disks can change, it must
next reply other threads:[~2009-05-19 16:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-19 16:07 raz ben yehuda [this message]
2009-05-20 1:39 ` Subject: [PATCH 008/009]: raid5: chunk size check in run Neil Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1242749263.3293.67.camel@raz \
--to=raziebe@gmail.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
--cc=ofer@bitband.com \
--cc=yaronp@bitband.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox