From: Peter Zijlstra <peterz@infradead.org>
To: David Rientjes <rientjes@google.com>
Cc: Theodore Tso <tytso@mit.edu>, Jens Axboe <jaxboe@fusionio.com>,
Andrew Morton <akpm@linux-foundation.org>,
Neil Brown <neilb@suse.de>, Alasdair G Kergon <agk@redhat.com>,
Chris Mason <chris.mason@oracle.com>,
Steven Whitehouse <swhiteho@redhat.com>, Jan Kara <jack@suse.cz>,
Frederic Weisbecker <fweisbec@gmail.com>,
"linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
"cluster-devel@redhat.com" <cluster-devel@redhat.com>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
"reiserfs-devel@vger.kernel.org" <reiserfs-devel@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [patch 1/5] mm: add nofail variants of kmalloc kcalloc and kzalloc
Date: Wed, 25 Aug 2010 23:27:57 +0200 [thread overview]
Message-ID: <1282771677.1975.138.camel@laptop> (raw)
In-Reply-To: <alpine.DEB.2.00.1008251406260.20253@chino.kir.corp.google.com>
On Wed, 2010-08-25 at 14:11 -0700, David Rientjes wrote:
>
> There's still no hard guarantee that the memory will allocatable
> (GFP_KERNEL, the compaction, then GFP_ATOMIC could all still fail), but I
> don't see how continuously looping the page allocator is possibly supposed
> to help in these situations.
Why do you think I'm a proponent of that behaviour?
I've been arguing that the existance of GFP_NOFAIL is the bug, and I
started the whole discussion because your patchset didn't outline the
purpose of its existance, it merely changes __GFP_NOFAIL usage into
$foo_nofail() functions, which on its own is a rather daft change.
Optimizing the page allocator by removing those conditional from its
innards into an outer loop not used by most callers seems a fine goal,
but you didn't state that.
Also, I like the postfix proposed by Andi better: _i_suck() :-)
next prev parent reply other threads:[~2010-08-25 21:27 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-24 10:50 [patch 1/5] mm: add nofail variants of kmalloc kcalloc and kzalloc David Rientjes
2010-08-24 12:15 ` Jan Kara
2010-08-24 13:29 ` Peter Zijlstra
2010-08-24 13:33 ` Jens Axboe
2010-08-24 20:11 ` David Rientjes
2010-08-25 11:24 ` Ted Ts'o
2010-08-25 11:35 ` Peter Zijlstra
2010-08-25 11:57 ` Ted Ts'o
2010-08-25 12:48 ` Peter Zijlstra
2010-08-25 12:52 ` Peter Zijlstra
2010-08-25 13:20 ` Theodore Tso
2010-08-25 13:31 ` Peter Zijlstra
2010-08-25 20:43 ` David Rientjes
2010-08-25 20:55 ` Peter Zijlstra
2010-08-25 21:11 ` David Rientjes
2010-08-25 21:27 ` Peter Zijlstra [this message]
2010-08-25 23:11 ` David Rientjes
2010-08-26 0:19 ` Ted Ts'o
2010-08-26 0:30 ` David Rientjes
2010-08-26 1:48 ` Ted Ts'o
2010-08-26 3:09 ` David Rientjes
2010-08-26 6:38 ` Dave Chinner
[not found] ` <alpine.DEB.2.00.1008251951230.7034@chino.kir.corp.google.com>
2010-08-26 7:06 ` Dave Chinner
2010-08-26 8:29 ` Peter Zijlstra
2010-08-25 13:34 ` Peter Zijlstra
2010-08-25 13:24 ` Dave Chinner
2010-08-25 13:35 ` Peter Zijlstra
2010-08-25 20:53 ` Ted Ts'o
2010-08-25 20:59 ` David Rientjes
2010-08-25 21:35 ` Peter Zijlstra
2010-08-25 20:58 ` David Rientjes
2010-08-25 21:11 ` Christoph Lameter
2010-08-25 21:21 ` Peter Zijlstra
2010-08-25 21:23 ` David Rientjes
2010-08-25 21:35 ` Christoph Lameter
2010-08-25 23:05 ` David Rientjes
2010-08-26 1:30 ` Christoph Lameter
2010-08-26 3:12 ` David Rientjes
2010-08-26 14:16 ` Christoph Lameter
2010-08-26 22:31 ` David Rientjes
2010-08-26 0:09 ` Dave Chinner
2010-08-25 14:13 ` Peter Zijlstra
2010-08-24 13:55 ` Dave Chinner
2010-08-24 14:03 ` Peter Zijlstra
2010-08-24 20:12 ` David Rientjes
2010-08-24 20:08 ` David Rientjes
2010-09-02 1:02 ` [patch v2 " David Rientjes
2010-09-02 7:59 ` Jiri Slaby
2010-09-02 14:51 ` Jan Kara
2010-09-02 21:15 ` Neil Brown
2010-09-05 23:03 ` David Rientjes
2010-09-05 23:01 ` David Rientjes
2010-09-06 9:05 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1282771677.1975.138.camel@laptop \
--to=peterz@infradead.org \
--cc=agk@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=chris.mason@oracle.com \
--cc=cluster-devel@redhat.com \
--cc=fweisbec@gmail.com \
--cc=jack@suse.cz \
--cc=jaxboe@fusionio.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
--cc=reiserfs-devel@vger.kernel.org \
--cc=rientjes@google.com \
--cc=swhiteho@redhat.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).