From: Kulikov Vasiliy <segooon@gmail.com>
To: kernel-janitors@vger.kernel.org
Cc: Vasiliy Kulikov <segooon@gmail.com>, Neil Brown <neilb@suse.de>,
Jens Axboe <jaxboe@fusionio.com>,
linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] md: do not use ++ in rcu_dereference() argument
Date: Sun, 5 Sep 2010 22:32:18 +0400 [thread overview]
Message-ID: <1283711539-7123-1-git-send-email-segooon@gmail.com> (raw)
From: Vasiliy Kulikov <segooon@gmail.com>
rcu_dereference() is macro, so it might use its argument twice.
Argument must not has side effects.
It was found by compiler warning:
drivers/md/raid1.c: In function ‘read_balance’:
drivers/md/raid1.c:445: warning: operation on ‘new_disk’ may be undefined
Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
---
drivers/md/raid1.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
index ad83a4d..12194df 100644
--- a/drivers/md/raid1.c
+++ b/drivers/md/raid1.c
@@ -442,7 +442,7 @@ static int read_balance(conf_t *conf, r1bio_t *r1_bio)
r1_bio->bios[new_disk] == IO_BLOCKED ||
!rdev || !test_bit(In_sync, &rdev->flags)
|| test_bit(WriteMostly, &rdev->flags);
- rdev = rcu_dereference(conf->mirrors[++new_disk].rdev)) {
+ rdev = rcu_dereference(conf->mirrors[new_disk].rdev)) {
if (rdev && test_bit(In_sync, &rdev->flags) &&
r1_bio->bios[new_disk] != IO_BLOCKED)
@@ -452,6 +452,7 @@ static int read_balance(conf_t *conf, r1bio_t *r1_bio)
new_disk = wonly_disk;
break;
}
+ new_disk++;
}
goto rb_out;
}
--
1.7.0.4
next reply other threads:[~2010-09-05 18:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-05 18:32 Kulikov Vasiliy [this message]
2010-09-05 19:01 ` [PATCH] md: do not use ++ in rcu_dereference() argument Sam Ravnborg
2010-09-05 19:23 ` Kulikov Vasiliy
2010-09-05 20:39 ` Sam Ravnborg
2010-09-06 5:29 ` Neil Brown
2010-09-06 7:43 ` walter harms
2010-09-06 11:05 ` Neil Brown
2010-09-06 19:21 ` Sam Ravnborg
2010-09-08 7:04 ` Neil Brown
2010-09-16 12:54 ` Avi Kivity
2010-09-17 3:18 ` Neil Brown
2010-09-06 20:10 ` Arnd Bergmann
2010-09-07 19:21 ` Kulikov Vasiliy
2010-09-07 20:00 ` Arnd Bergmann
2010-09-07 20:50 ` Paul E. McKenney
2010-09-09 15:14 ` Arnd Bergmann
2010-09-10 3:46 ` Paul E. McKenney
2010-09-14 0:33 ` Paul E. McKenney
2010-09-15 12:28 ` Arnd Bergmann
2010-09-16 6:15 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1283711539-7123-1-git-send-email-segooon@gmail.com \
--to=segooon@gmail.com \
--cc=jaxboe@fusionio.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).