From: James Bottomley <James.Bottomley@suse.de>
To: device-mapper development <dm-devel@redhat.com>
Cc: NeilBrown <neilb@suse.de>, Jens Axboe <axboe@kernel.dk>,
linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [dm-devel] [PATCH] Fix over-zealous flush_disk when changing device size.
Date: Mon, 07 Mar 2011 10:46:58 -0600 [thread overview]
Message-ID: <1299516418.15258.4.camel@mulgrave.site> (raw)
In-Reply-To: <1299471771.2228.11.camel@grinch>
On Sun, 2011-03-06 at 21:22 -0700, Andrew Patterson wrote:
> On Sun, 2011-03-06 at 17:47 +1100, NeilBrown wrote:
> > Would you be uncomfortable if I asked Linus to revert both my fix and your
> > original patch??
>
> James Bottomley wanted me to put this functionality in. I have no
> problem with reverting it myself, especially if it is causing other
> problems. I would have to say that you need to ask him (or rather, I am
> not qualified to render an opinion here).
So it seems we have a couple of problems: the first being that
flush_disk() doesn't actually do what it says (flush the disk). If it's
just discarding all data, dirty or clean, then its use in the
grow/shrink interface is definitely wrong.
The idea is that before we complete the grow/shrink, we make sure that
the device doesn't have any errors, so we want to try to write out all
dirty buffers to make sure they still have a home. If flush_disk()
doesn't do that, then we need to use a different interface ... what's
the interface to flush a disk?
James
next prev parent reply other threads:[~2011-03-07 16:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-17 5:50 [PATCH] Fix over-zealous flush_disk when changing device size NeilBrown
2011-02-17 17:03 ` Jeff Moyer
2011-02-23 8:48 ` Kwolek, Adam
2011-02-23 10:01 ` NeilBrown
2011-02-21 19:36 ` Jeff Moyer
2011-02-21 21:14 ` NeilBrown
2011-03-03 14:31 ` Christoph Hellwig
2011-03-04 0:16 ` NeilBrown
2011-03-04 17:25 ` Andrew Patterson
2011-03-06 6:47 ` NeilBrown
2011-03-07 4:22 ` Andrew Patterson
2011-03-07 16:46 ` James Bottomley [this message]
2011-03-07 22:44 ` [dm-devel] " NeilBrown
2011-03-07 22:56 ` James Bottomley
2011-03-08 0:04 ` NeilBrown
2011-03-16 20:30 ` Jeff Moyer
2011-03-17 1:28 ` NeilBrown
2011-03-17 17:33 ` Jeff Moyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1299516418.15258.4.camel@mulgrave.site \
--to=james.bottomley@suse.de \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).